-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table: Add a dropdown with checkboxes to show/hide specific columns + reorder the columns #233
Comments
@andrewtpham, I'm looking at the table and I'm not sure if the settings button will fit properly 🤔 |
@andrewtpham what about right-clicking on a header column in order to bring up the menu? |
@michaelbukachi Could we create the settings icon a row above the main header? See in this example, we could add the icon somewhere above (see purple highlight): |
we can also have the last column fixed. https://element.eleme.io/#/en-US/component/table#table-with-fixed-column |
Yes! I like the fixed column if that works for @michaelbukachi |
Alright. I'll start implementing this. |
@andrewtpham @ninetteadhikari |
@michaelbukachi This looks great! I really like how it works. Here's some feedback points (cc @ninetteadhikari):
|
|
The preview link: |
Also. I'm not sure if it's just my computer. But I get a bit of lag when I hide/show columns 🤔 |
@michaelbukachi For the styling of drag and drop to re-order the column order, we can follow something like this? |
@michaelbukachi Apologies for the many examples but wanted to share this in case some of the styling is easier to implement: The main things to keep in mind for the
|
@andrewtpham |
Here's the line indicator: |
@michaelbukachi Could we use one of these for our drag and drop icon, which do you prefer given the screen real estate? Also, do you think it should be on the right side? https://fontawesome.com/v6.0/icons/grip-vertical?s=solid |
@michaelbukachi This is perfect! Nicely done 🙌 |
With this, we'd have to introduce fontawesome into hakawati. But it seems we don't have an alternative. |
@michaelbukachi Ok, let's skip fontawesome for now. Do you think we could use |
@michaelbukachi On second thought, let's get this PR merged and I'll ticket the icon in a separate enhancement for the future. Maybe we'll find a better icon to use by then 🙆♂️ |
Is your feature request related to a problem? Please describe.
We would like the ability for a user to select which columns to display and re-order in the table view
Additional context
Here is a quick mock up of the dropdown menu (apologies its so messy), still getting the hang of figma 🙈
The text was updated successfully, but these errors were encountered: