build: bump hiero-gradle-conventions to 0.3.4 / correct requires static #17876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjohannes
force-pushed
the
deps-gradle-convnetions-0.3.4
branch
from
1647d2a to
c336ba8
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17876 +/- ##
============================================
+ Coverage 69.01% 69.02% +0.01%
- Complexity 23050 23053 +3
============================================
Files 2655 2655
Lines 99675 99675
Branches 10289 10289
============================================
+ Hits 68795 68805 +10
+ Misses 26981 26979 -2
+ Partials 3899 3891 -8 see 12 files with indirect coverage changes |
timo0
previously approved these changes
Feb 13, 2025
lpetrovic05
previously approved these changes
Feb 14, 2025
jjohannes
force-pushed
the
deps-gradle-convnetions-0.3.4
branch
from
1a72868 to
8fcc5fb
Compare
The dependency analysis - through the update of the plugin to 2.8.x -
now does a better job analyzing "requires static" dependencies.
That's why the update makes the check fail.
This PR changes:
- 'requires static com.github.spotbugs.annotations' for 'main' code to
'requires static transitive com.github.spotbugs.annotations'
- Removes 'requiresStatic("com.github.spotbugs.annotations")' for unit
tests as this is inherited from main code dependencies
Signed-off-by: Jendrik Johannes <[email protected]>
jjohannes
force-pushed
the
deps-gradle-convnetions-0.3.4
branch
from
8fcc5fb to
b325a6d
Compare
thenswan
approved these changes
Feb 20, 2025
timo0
approved these changes
Feb 20, 2025
mhess-swl
approved these changes
Feb 20, 2025
andrewb1269hg
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The dependency analysis - through the update of the plugin to 2.8.x - now does a better job analyzing "requires static" dependencies. That's why the update makes the check fail.
This PR changes:
requires static com.github.spotbugs.annotationsformaincode torequires static transitive com.github.spotbugs.annotationsrequiresStatic("com.github.spotbugs.annotations")for unit tests as this is inherited from main code dependencies