Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Snyk Integration #2224

Merged
merged 30 commits into from
Feb 13, 2025
Merged

chore: Snyk Integration #2224

merged 30 commits into from
Feb 13, 2025

Conversation

rbarker-dev
Copy link
Member

@rbarker-dev rbarker-dev commented Feb 11, 2025 •
edited
Loading

Add snyk_monitor.yml and add Snyk checks in CI during build.

@rbarker-dev rbarker-dev self-assigned this Feb 11, 2025
@rbarker-dev rbarker-dev requested review from a team as code owners February 11, 2025 17:22
@rbarker-dev rbarker-dev linked an issue Feb 11, 2025 that may be closed by this pull request
Simple modifications to test snyk #2223
Closed
@rbarker-dev
Update to include Snyk workflows
07ece70 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Set up node
8078723 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Added .snyk file
837fd1b 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev rbarker-dev requested a review from a team as a code owner February 11, 2025 20:11
@rbarker-dev
Add known ignore files
e4dcea0 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Update fetch-depth
df5b409 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev rbarker-dev changed the title chore: Test PR for Snyk Integration (DO NOT MERGE) chore: Snyk Integration Feb 11, 2025
@rbarker-dev
Remove exclusions on snyk
04b6cc2 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Intentionally break snyk-monitor so i can do the workflow dispatch
f5919cc 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
fix snyk-monitor.yml
ac06b8d 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Changed test flags on monitor and test
a567f88 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Update .snyk
f755d6e 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Update grpc val to 1.70.0 to fix snyk issues
7236216 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Remove excludes in .snyk
31a3aa7 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Update grpc version to 1.70.0 except for grpc-netty-shaded.
6f2c1c7 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Reset grpc val to 1.69.1 temporarily
053c569 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev
Update grpc to 1.70.0
6746c60 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev rbarker-dev mentioned this pull request Feb 12, 2025
Closed
@rbarker-dev rbarker-dev requested a review from a team as a code owner February 12, 2025 14:55
@rbarker-dev
Updating comment
c6b26c5 
Signed-off-by: Roger Barker <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...java/com/hedera/hashgraph/sdk/PrivateKeyECDSA.java 85.71% <ø> (ø) 24.00 <0.00> (?)
...va/com/hedera/hashgraph/sdk/PrivateKeyED25519.java 89.47% <ø> (ø) 23.00 <0.00> (?)

@rbarker-dev
empty-commit
e60e138 
Signed-off-by: Roger Barker <[email protected]>
@rbarker-dev rbarker-dev reopened this Feb 13, 2025
nathanklick
nathanklick previously approved these changes Feb 13, 2025
View reviewed changes
@rbarker-dev rbarker-dev requested review from jjohannes and PavelSBorisov and removed request for jjohannes February 13, 2025 08:06
jjohannes
jjohannes reviewed Feb 13, 2025
View reviewed changes
jjohannes
jjohannes suggested changes Feb 13, 2025
View reviewed changes
0xivanov
0xivanov approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbarker-dev rbarker-dev merged commit da263f7 into main Feb 13, 2025
8 checks passed
@rbarker-dev rbarker-dev deleted the 2223-simple-modifications-to-test-snyk branch February 13, 2025 08:52
@0xivanov 0xivanov mentioned this pull request Feb 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjohannes jjohannes jjohannes approved these changes

@PavelSBorisov PavelSBorisov PavelSBorisov approved these changes

@0xivanov 0xivanov 0xivanov approved these changes

@jsync-swirlds jsync-swirlds jsync-swirlds approved these changes

@nathanklick nathanklick nathanklick left review comments

@dr20240304 dr20240304 Awaiting requested review from dr20240304

@andrewb1269hg andrewb1269hg Awaiting requested review from andrewb1269hg

Assignees

@rbarker-dev rbarker-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simple modifications to test snyk
6 participants
@rbarker-dev @jjohannes @nathanklick @PavelSBorisov @0xivanov @jsync-swirlds