Disable thread actions for users that have not joined the community #4521

masvelio · 2023-07-18T13:11:07Z

Link to Issue

Closes: #4378

Description of Changes

before I got into the feature itself, I have done some refactoring and tidy up the code a bit, including file renames and movements (so please note that most green lines are because of the file name/location change)
- We should not keep the component in the index.ts file because it is hard to find the proper file or component
- We should name file and component exactly the same way - this makes searching files/components much easier
- I applied above changes to: CommentCard, CommentTree, HeaderWithFilters, AuthorAndPublishInfo, AdminActions, ThreadOptions
Created CWUpvoteSmall button that is used for reaction button in order to unify components
Extended cw_thread_aciton component to handle selected state (different icons) and displaying tooltip
Added temporary styles for the tooltip (I use the old tooltip but I just made it black as it is on the new designs). It have to be swapped later when Design System: Tooltips #4123 will be finished

Kapture.2023-07-20.at.17.17.45.mp4

Test Plan

when you are part of the community you can comment, upvote, subscribe etc
when you are not part of the community you should see disabled buttons (upvote, comment, subscribe, reply) and the tooltip should appear when you hover over those buttons
if you click join button, you should immediately be able to vote, comment etc and the tooltip won't be visible anymore

Other Considerations

Some more related work will be done in Session Keys: UX Update to Disable Actions #4317

…a-banner # Conflicts: # packages/commonwealth/client/scripts/views/pages/view_thread/ViewThreadPage.tsx # packages/commonwealth/static/fonts/fonts.css

…a-banner

…-thread-actions # Conflicts: # packages/commonwealth/client/scripts/views/components/ReactionButton/CommentReactionButton.tsx

jessmart1213 · 2023-07-24T15:09:50Z

Looks amazing! @masvelio ! I have no updates / no tweaks, the copy is good, the solution to have the tooltip center within the editor feels right, and all the right actions are disabled when a user is not joined. Thank you for all your hard work, this is really great!

meeshlin · 2023-07-25T14:43:38Z

Approved, looks correct according to spec.

@zakhap In terms of fast follows, we need to hide the Quill editor if a user can't leave a comment as well as the Subscribe action button. There's no point. Even the tooltips feel a bit excessive.

cc: @jnaviask @masvelio

…4521) * Quill initial work * Add monospace font on markdown * Add focus styles * Add disabled state * prevent jump between markdown toggle * Adjust quill all over the app * Update icons to phosphor * Add quill to component showcase * Remove placeholder default text * Add banner component * Add static banner to view thread page * Add static banner to create thread page * Add closing banner in new thread form * Add closing banner in discussion page * Abstract join community logic into hook * use join community hook in new thread form * use join community hook in view thread page * use hook for check active account * use hook for closing banner logic * abstract AccountSelectorModal * abstract TOS modal * abstract all join community modals modals * rename old banner and create new component for join community banner * Fix ts errors * Revert merge changes * Disable editor 4377 * Change naming * Change naming pt. 2 * Change naming pt. 3 * Unify small upvote button * Remove upvote from thread action component * Replace comment button * Replace share button * Replace subscribe btn * Replace overflow btn * add upvote to thread action component * Change div to button * Progress on disabling * Add tooltip wrapper to thread action * Edit tooltip styles to adjust new designs * Add tooltip to disabled buttons * Handle reply button * Fix create thread buttons * self CR * fixed lint errors * remove comment * conflicts --------- Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Muon Shot <[email protected]>

* long topic css (#4506) * Show join community banner when user has not joined (#4488) * Quill initial work * Add monospace font on markdown * Add focus styles * Add disabled state * prevent jump between markdown toggle * Adjust quill all over the app * Update icons to phosphor * Add quill to component showcase * Remove placeholder default text * Add banner component * Add static banner to view thread page * Add static banner to create thread page * Add closing banner in new thread form * Add closing banner in discussion page * Abstract join community logic into hook * use join community hook in new thread form * use join community hook in view thread page * use hook for check active account * use hook for closing banner logic * abstract AccountSelectorModal * abstract TOS modal * abstract all join community modals modals * rename old banner and create new component for join community banner * Fix ts errors * Revert merge changes --------- Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Muon Shot <[email protected]> * fix deleted thread page (#4509) Co-authored-by: Jake Naviasky <[email protected]> * add unit test for delete comment (#4501) * Archive backend (#4440) * add routes to archive or unarchive thread * block thread reactions and thread comments if archived * typo * update achive/spam routes * fix UI after API changes * tweak * apply feedback + add reusable permissions func * async await for threads --------- Co-authored-by: Muon Shot <[email protected]> * Cleanup /createRole and /deleteRole apis + frontend (#4502) * Cleanup /createRole and /deleteRole from frontend * Cleanup /createRole and /deleteRole APIs * Fix lint issues * Refresh user dashboard feed section after login (#4395) * Refresh user dashboard feed section after login * Fixed lint issues * Fixed lint issues * if cosmos prefix, truncate after the prefix plus 3 chars: vote result and popover (#4518) * Disable Editor with tooltip (#4513) * Quill initial work * Add monospace font on markdown * Add focus styles * Add disabled state * prevent jump between markdown toggle * Adjust quill all over the app * Update icons to phosphor * Add quill to component showcase * Remove placeholder default text * Add banner component * Add static banner to view thread page * Add static banner to create thread page * Add closing banner in new thread form * Add closing banner in discussion page * Abstract join community logic into hook * use join community hook in new thread form * use join community hook in view thread page * use hook for check active account * use hook for closing banner logic * abstract AccountSelectorModal * abstract TOS modal * abstract all join community modals modals * rename old banner and create new component for join community banner * Fix ts errors * Revert merge changes * Disable editor 4377 --------- Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Muon Shot <[email protected]> * Fix user dashboard avatar group crash. (#4478) * Fix user dashboard avatar group crash. * Update to avoid case with no valid profiles. * fix check for paginated requests (#4489) completed proposals 30 minutes, active proposals 5 minutes block test status test short cache handle individual proposal cache extensions add case to isolate v1 active proposal live vote data cache individual proposal for 1 week catch different params requests so they don't all go under same cache key test for specififc params request shorten live proposal requests key and duration tests (3) fix live proposal vote data cache key, test test key and duration for all proposals rpc test key and duration for all rpc test duration all LCD * do not test cache for live proposals (would need to create a prop to test in CI) (#4529) * Wrote migration script to update broken chainNodes (#4522) * Wrote migration script to update eth chainNode * Fixed BNB chainNode * Fixed Fantom Opera chainNode * Client Side Image Compression (#4517) * image compression on client * set options for compression * Downgrade quill. --------- Co-authored-by: Jake Naviasky <[email protected]> * POC of new topic gating flow (#4485) * POC of new gating flow * add balance to account model * async token balance check * update balance type * bug fixes * make token balance fetch reuseable * solana support + fixes * typecheck fix * PR comments, replace name with Id * null check userBalance * force balance for comment if not aquired * rm console.log * reactive loading of threshold data --------- Co-authored-by: Jake Naviasky <[email protected]> * Fix sidebar z-index (#4544) * Initial draft of new templates. (#4547) * fix CSS for loading indicator (#4552) * Migrated reactions state to react query (#4426) * Migrated thread add/delete reaction queries to react query * Migrated comment add/delete reaction queries to react query * Migrated fetch comment reactions query to react query * Merged reaction controller state with comments controller * Migrated (half) reactionCounts query to react query files * Fix type check * Code linted and updated letter case for some func * removed extra comment * Remove .then from react query queries * "One click" - Creating snapshot from thread (#3888) * add scaffold ui for creating snapshot from thread * poc modal * update form styling * add selector if multiple spaces and event emitter * update styling * add ability to link auto once snapshot created * pass in thread to snapshot default * update thread * send rich text to Snapshot * add link * get autolink to work * resolve comments * Fix typecheck. * modal min sizing * disclaimer * revert * disclaimer * Only show create snapshot option if no snapshot proposal exists for thread * Only show 1 click snapshot (1cs) on communities that support snapshot * Updated snapshot field label * Only add unique snapshot spaces --------- Co-authored-by: Jake Naviasky <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Malik Zulqurnain <[email protected]> * Aave/Dydx Proposal Loading Fix (#4567) * first attempt * clean * Disable thread actions for users that have not joined the community (#4521) * Quill initial work * Add monospace font on markdown * Add focus styles * Add disabled state * prevent jump between markdown toggle * Adjust quill all over the app * Update icons to phosphor * Add quill to component showcase * Remove placeholder default text * Add banner component * Add static banner to view thread page * Add static banner to create thread page * Add closing banner in new thread form * Add closing banner in discussion page * Abstract join community logic into hook * use join community hook in new thread form * use join community hook in view thread page * use hook for check active account * use hook for closing banner logic * abstract AccountSelectorModal * abstract TOS modal * abstract all join community modals modals * rename old banner and create new component for join community banner * Fix ts errors * Revert merge changes * Disable editor 4377 * Change naming * Change naming pt. 2 * Change naming pt. 3 * Unify small upvote button * Remove upvote from thread action component * Replace comment button * Replace share button * Replace subscribe btn * Replace overflow btn * add upvote to thread action component * Change div to button * Progress on disabling * Add tooltip wrapper to thread action * Edit tooltip styles to adjust new designs * Add tooltip to disabled buttons * Handle reply button * Fix create thread buttons * self CR * fixed lint errors * remove comment * conflicts --------- Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Muon Shot <[email protected]> * Fix incorrect reaction removal on details page (#4557) * Fix incorrect comment reaction state getting assigned to thread reaction state * Removed unnecessary threadIdToReactions state * Fix login modal in not-yet-joined community. (#4571) * fix login modal * shorter * Adds new design to 'Join community' button (#4493) * first commit * add buttonWidth full * edit new design Button stories * edit css classes * removed getTextType function * Fixes --------- Co-authored-by: Marcin Maslanka <[email protected]> * Update bug_report.md (#4583) * Introduce 405 HTTP errors (#3855) * 405 for CE-app * CW routes refactored to use registerRoutes * methodNotAllowedMiddleware fix * snapshot 405 * return 404 from middleware * remove logs + /api from snapshot * revert 404 returning -> separate PR due to CI issue * add types to registerRoute functions * remove CE test routes * remove duplicate route (forgot to push) * Bump yarn.lock. * Resolved merge conflicts * fix merge conflicts + add ValidateChain type * docs * doc fix * added methodNotAllowed test * globbing fix * Undo globbing * Revert "Undo globbing" This reverts commit 2711e55. * fix bug introduced in master merge --------- Co-authored-by: Jake Naviasky <[email protected]> Co-authored-by: kassad <[email protected]> Co-authored-by: Muon Shot <[email protected]> * Fix production memory logging error (#4281) * log memory * round to int with awk * remove unnecessary logs --------- Co-authored-by: Muon Shot <[email protected]> * Discard old Notifications and Subscriptions (#4410) * databaseCleaner init + migration revert * databaseCleaner clean-up functions + added to server.ts * dbCleaner use UTC + tests * name fix in CI * clean-up test logs + don't leave setTimeout funcs hanging * clearer log for undefined hourToRun * migration reversal * drop NR fkey constraints * rename/reorder migrations * Replace validateRoles with validateOwner (#4591) * replace all instances of validateRoles with validateOwner * fix import paths * Discord Bot: Listener + Consumer + UI changes (#4323) * poc of discord listener * Integrate Listener/consumer with RMQ Racal config * callback page * fixes * removed bot ui from the loop * no make sense * update consumer for push * add readme * add tsconfig * prog * prog * discord bot connection ui * WIP Discord bot Worker (#4349) * Prototype Worker * update migration * custom bot route * Add bot key validation * update demo * comment keyt additions * Discord Bot UI feature branch merge (#4393) * callback page * fixes * removed bot ui from the loop * no make sense * prog * prog * discord bot connection ui --------- Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> * discord bot user profile * down migration for users * migration fix * formatting * loading fix * consolidate migrations and add comment metadata * update readme * fix for saving settings * transactionalize migrations * fix for discord callback page * add procfile * discord bor build commands * add config * update proc * procfile space size * procfile update * update package.json * package.json fix * test strict false + log memory * transpile only ts-node * switch to node + local node running sripts * fix node path * fix package json * add link to all threads * discord tags * link to top * comment tags * locking * merge resulting changes * empty state * discord tag * fixes * prog * discord bot ui fixes * match channel ids * catch self changing case * fix remove topics * fix connections * fix edge cases on connections * confirmation modal * Update discobot README with diagram * switch test endpoint to correct endpoint * switch test endpoint to correct endpoint again * remove snapshot * migration to remove existing bot configs * fixes for merge * add statsd support * switch bot packages to devdependencies * switch ts version --------- Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Timothee Legros <[email protected]> * fix searchProfiles infinite loop on members page (#4602) * Subpage Routes for Create Community (#4598) * subpage routes for create community * redirect * fix * #4118: thread tag design (#4400) * update buttons and component showcase * add margins on secondary and tertiary buttons * isolate new button designs from rest of app * complete button stories; styling improvements * add medium neue haas unica font to buttons * set button type correctly * update styles for thread previews * always display dot in thread preview * create second bell icon so as not to effect current bell icons * fix alignments in thread preview bottom menu * add new arrow icons to thread previews * add new arrow icons for small reaction arrow * re-insert thread preview styling * remove unused files * WIP: add tags * add stories around new tag designs * linter appeasement * restore styles * fix bug wherein upvote button did not display * remove unnecessary padding from footer options * remove styling hack from component * Database Cleaner Updates (#4594) * singleton pattern + redis locking + scripting method * fix lint errors * remove async + fix tests * naming fix * fix RedisCache setKey method * increase timeout to 12 hours for long-running operations * Session keys - UI components (#4584) * Add connection indicator * Add join button * Add switch address banner * CR * Design System - Banners and alerts (#4593) * Create story for banner * Add banners to component showcase * Add alerts to storybook and showcase * Fix ts error --------- Co-authored-by: Marcin Maslanka <[email protected]> --------- Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Jake Naviasky <[email protected]> * fix (#4613) * discord bot image handling (#4615) * Update pagination (API + UI) (#4508) * pagination wip * profiles * remove empty file * react-query pagination WIP * react query pagination works - initial implementation * fix search dupes by using secondary sort * generally works * wip * fixes * fix navigation * fix search bar * cleanup * undo change * refactor members page to react query * fix manage page * remove comment + remove old createReaction route * fix quill mentions member search * restore yarn lock file * cleanup * typo * apply feedback * remove ttlcache * fix members scroll bug * fix url * fix collab modal * cleanup * Fix stats middleware (cw.path.called) (#4617) * fix stats middleware * typo * Update yarn.lock. --------- Co-authored-by: Jake Naviasky <[email protected]> * 4121 design thread listing (#4191) * update buttons and component showcase * add margins on secondary and tertiary buttons * isolate new button designs from rest of app * complete button stories; styling improvements * add medium neue haas unica font to buttons * set button type correctly * update styles for thread previews * always display dot in thread preview * create second bell icon so as not to effect current bell icons * fix alignments in thread preview bottom menu * add new arrow icons to thread previews * add new arrow icons for small reaction arrow * re-insert thread preview styling * remove unused files * restore styles * fix bug wherein upvote button did not display * remove unnecessary padding from footer options * remove styling hack from component * downcase label on new tags * center user id text * fix error handling on discord channel fetch (#4622) * always show community allow user set visibility on sidebar * ensure local storage visibility pref correct * remember menu state on other menus * sides in and out instead of just appearing * made desktop sidebar draggable * add desktop platform notifs --------- Co-authored-by: Alex Young <[email protected]> Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Muon Shot <[email protected]> Co-authored-by: Jake Naviasky <[email protected]> Co-authored-by: Ryan Bennett <[email protected]> Co-authored-by: Malik Zulqurnain <[email protected]> Co-authored-by: Mark Hagelberg <[email protected]> Co-authored-by: Kurtis Assad <[email protected]> Co-authored-by: Ian Rowan <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Malik Zulqurnain <[email protected]> Co-authored-by: Daniel Martins <[email protected]> Co-authored-by: Timothee Legros <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Timothee Legros <[email protected]> Co-authored-by: Ifu Aniemeka <[email protected]>

* long topic css (#4506) * Show join community banner when user has not joined (#4488) * Quill initial work * Add monospace font on markdown * Add focus styles * Add disabled state * prevent jump between markdown toggle * Adjust quill all over the app * Update icons to phosphor * Add quill to component showcase * Remove placeholder default text * Add banner component * Add static banner to view thread page * Add static banner to create thread page * Add closing banner in new thread form * Add closing banner in discussion page * Abstract join community logic into hook * use join community hook in new thread form * use join community hook in view thread page * use hook for check active account * use hook for closing banner logic * abstract AccountSelectorModal * abstract TOS modal * abstract all join community modals modals * rename old banner and create new component for join community banner * Fix ts errors * Revert merge changes --------- Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Muon Shot <[email protected]> * fix deleted thread page (#4509) Co-authored-by: Jake Naviasky <[email protected]> * add unit test for delete comment (#4501) * Archive backend (#4440) * add routes to archive or unarchive thread * block thread reactions and thread comments if archived * typo * update achive/spam routes * fix UI after API changes * tweak * apply feedback + add reusable permissions func * async await for threads --------- Co-authored-by: Muon Shot <[email protected]> * Cleanup /createRole and /deleteRole apis + frontend (#4502) * Cleanup /createRole and /deleteRole from frontend * Cleanup /createRole and /deleteRole APIs * Fix lint issues * Refresh user dashboard feed section after login (#4395) * Refresh user dashboard feed section after login * Fixed lint issues * Fixed lint issues * if cosmos prefix, truncate after the prefix plus 3 chars: vote result and popover (#4518) * Disable Editor with tooltip (#4513) * Quill initial work * Add monospace font on markdown * Add focus styles * Add disabled state * prevent jump between markdown toggle * Adjust quill all over the app * Update icons to phosphor * Add quill to component showcase * Remove placeholder default text * Add banner component * Add static banner to view thread page * Add static banner to create thread page * Add closing banner in new thread form * Add closing banner in discussion page * Abstract join community logic into hook * use join community hook in new thread form * use join community hook in view thread page * use hook for check active account * use hook for closing banner logic * abstract AccountSelectorModal * abstract TOS modal * abstract all join community modals modals * rename old banner and create new component for join community banner * Fix ts errors * Revert merge changes * Disable editor 4377 --------- Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Muon Shot <[email protected]> * Fix user dashboard avatar group crash. (#4478) * Fix user dashboard avatar group crash. * Update to avoid case with no valid profiles. * fix check for paginated requests (#4489) completed proposals 30 minutes, active proposals 5 minutes block test status test short cache handle individual proposal cache extensions add case to isolate v1 active proposal live vote data cache individual proposal for 1 week catch different params requests so they don't all go under same cache key test for specififc params request shorten live proposal requests key and duration tests (3) fix live proposal vote data cache key, test test key and duration for all proposals rpc test key and duration for all rpc test duration all LCD * do not test cache for live proposals (would need to create a prop to test in CI) (#4529) * Wrote migration script to update broken chainNodes (#4522) * Wrote migration script to update eth chainNode * Fixed BNB chainNode * Fixed Fantom Opera chainNode * Client Side Image Compression (#4517) * image compression on client * set options for compression * Downgrade quill. --------- Co-authored-by: Jake Naviasky <[email protected]> * POC of new topic gating flow (#4485) * POC of new gating flow * add balance to account model * async token balance check * update balance type * bug fixes * make token balance fetch reuseable * solana support + fixes * typecheck fix * PR comments, replace name with Id * null check userBalance * force balance for comment if not aquired * rm console.log * reactive loading of threshold data --------- Co-authored-by: Jake Naviasky <[email protected]> * Fix sidebar z-index (#4544) * Initial draft of new templates. (#4547) * fix CSS for loading indicator (#4552) * Migrated reactions state to react query (#4426) * Migrated thread add/delete reaction queries to react query * Migrated comment add/delete reaction queries to react query * Migrated fetch comment reactions query to react query * Merged reaction controller state with comments controller * Migrated (half) reactionCounts query to react query files * Fix type check * Code linted and updated letter case for some func * removed extra comment * Remove .then from react query queries * "One click" - Creating snapshot from thread (#3888) * add scaffold ui for creating snapshot from thread * poc modal * update form styling * add selector if multiple spaces and event emitter * update styling * add ability to link auto once snapshot created * pass in thread to snapshot default * update thread * send rich text to Snapshot * add link * get autolink to work * resolve comments * Fix typecheck. * modal min sizing * disclaimer * revert * disclaimer * Only show create snapshot option if no snapshot proposal exists for thread * Only show 1 click snapshot (1cs) on communities that support snapshot * Updated snapshot field label * Only add unique snapshot spaces --------- Co-authored-by: Jake Naviasky <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Malik Zulqurnain <[email protected]> * Aave/Dydx Proposal Loading Fix (#4567) * first attempt * clean * Disable thread actions for users that have not joined the community (#4521) * Quill initial work * Add monospace font on markdown * Add focus styles * Add disabled state * prevent jump between markdown toggle * Adjust quill all over the app * Update icons to phosphor * Add quill to component showcase * Remove placeholder default text * Add banner component * Add static banner to view thread page * Add static banner to create thread page * Add closing banner in new thread form * Add closing banner in discussion page * Abstract join community logic into hook * use join community hook in new thread form * use join community hook in view thread page * use hook for check active account * use hook for closing banner logic * abstract AccountSelectorModal * abstract TOS modal * abstract all join community modals modals * rename old banner and create new component for join community banner * Fix ts errors * Revert merge changes * Disable editor 4377 * Change naming * Change naming pt. 2 * Change naming pt. 3 * Unify small upvote button * Remove upvote from thread action component * Replace comment button * Replace share button * Replace subscribe btn * Replace overflow btn * add upvote to thread action component * Change div to button * Progress on disabling * Add tooltip wrapper to thread action * Edit tooltip styles to adjust new designs * Add tooltip to disabled buttons * Handle reply button * Fix create thread buttons * self CR * fixed lint errors * remove comment * conflicts --------- Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Muon Shot <[email protected]> * Fix incorrect reaction removal on details page (#4557) * Fix incorrect comment reaction state getting assigned to thread reaction state * Removed unnecessary threadIdToReactions state * Fix login modal in not-yet-joined community. (#4571) * fix login modal * shorter * Adds new design to 'Join community' button (#4493) * first commit * add buttonWidth full * edit new design Button stories * edit css classes * removed getTextType function * Fixes --------- Co-authored-by: Marcin Maslanka <[email protected]> * Update bug_report.md (#4583) * Introduce 405 HTTP errors (#3855) * 405 for CE-app * CW routes refactored to use registerRoutes * methodNotAllowedMiddleware fix * snapshot 405 * return 404 from middleware * remove logs + /api from snapshot * revert 404 returning -> separate PR due to CI issue * add types to registerRoute functions * remove CE test routes * remove duplicate route (forgot to push) * Bump yarn.lock. * Resolved merge conflicts * fix merge conflicts + add ValidateChain type * docs * doc fix * added methodNotAllowed test * globbing fix * Undo globbing * Revert "Undo globbing" This reverts commit 2711e55. * fix bug introduced in master merge --------- Co-authored-by: Jake Naviasky <[email protected]> Co-authored-by: kassad <[email protected]> Co-authored-by: Muon Shot <[email protected]> * Fix production memory logging error (#4281) * log memory * round to int with awk * remove unnecessary logs --------- Co-authored-by: Muon Shot <[email protected]> * Discard old Notifications and Subscriptions (#4410) * databaseCleaner init + migration revert * databaseCleaner clean-up functions + added to server.ts * dbCleaner use UTC + tests * name fix in CI * clean-up test logs + don't leave setTimeout funcs hanging * clearer log for undefined hourToRun * migration reversal * drop NR fkey constraints * rename/reorder migrations * Replace validateRoles with validateOwner (#4591) * replace all instances of validateRoles with validateOwner * fix import paths * Discord Bot: Listener + Consumer + UI changes (#4323) * poc of discord listener * Integrate Listener/consumer with RMQ Racal config * callback page * fixes * removed bot ui from the loop * no make sense * update consumer for push * add readme * add tsconfig * prog * prog * discord bot connection ui * WIP Discord bot Worker (#4349) * Prototype Worker * update migration * custom bot route * Add bot key validation * update demo * comment keyt additions * Discord Bot UI feature branch merge (#4393) * callback page * fixes * removed bot ui from the loop * no make sense * prog * prog * discord bot connection ui --------- Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> * discord bot user profile * down migration for users * migration fix * formatting * loading fix * consolidate migrations and add comment metadata * update readme * fix for saving settings * transactionalize migrations * fix for discord callback page * add procfile * discord bor build commands * add config * update proc * procfile space size * procfile update * update package.json * package.json fix * test strict false + log memory * transpile only ts-node * switch to node + local node running sripts * fix node path * fix package json * add link to all threads * discord tags * link to top * comment tags * locking * merge resulting changes * empty state * discord tag * fixes * prog * discord bot ui fixes * match channel ids * catch self changing case * fix remove topics * fix connections * fix edge cases on connections * confirmation modal * Update discobot README with diagram * switch test endpoint to correct endpoint * switch test endpoint to correct endpoint again * remove snapshot * migration to remove existing bot configs * fixes for merge * add statsd support * switch bot packages to devdependencies * switch ts version --------- Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Timothee Legros <[email protected]> * fix searchProfiles infinite loop on members page (#4602) * Subpage Routes for Create Community (#4598) * subpage routes for create community * redirect * fix * #4118: thread tag design (#4400) * update buttons and component showcase * add margins on secondary and tertiary buttons * isolate new button designs from rest of app * complete button stories; styling improvements * add medium neue haas unica font to buttons * set button type correctly * update styles for thread previews * always display dot in thread preview * create second bell icon so as not to effect current bell icons * fix alignments in thread preview bottom menu * add new arrow icons to thread previews * add new arrow icons for small reaction arrow * re-insert thread preview styling * remove unused files * WIP: add tags * add stories around new tag designs * linter appeasement * restore styles * fix bug wherein upvote button did not display * remove unnecessary padding from footer options * remove styling hack from component * Database Cleaner Updates (#4594) * singleton pattern + redis locking + scripting method * fix lint errors * remove async + fix tests * naming fix * fix RedisCache setKey method * increase timeout to 12 hours for long-running operations * Session keys - UI components (#4584) * Add connection indicator * Add join button * Add switch address banner * CR * Design System - Banners and alerts (#4593) * Create story for banner * Add banners to component showcase * Add alerts to storybook and showcase * Fix ts error --------- Co-authored-by: Marcin Maslanka <[email protected]> --------- Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Jake Naviasky <[email protected]> * fix (#4613) * discord bot image handling (#4615) * Update pagination (API + UI) (#4508) * pagination wip * profiles * remove empty file * react-query pagination WIP * react query pagination works - initial implementation * fix search dupes by using secondary sort * generally works * wip * fixes * fix navigation * fix search bar * cleanup * undo change * refactor members page to react query * fix manage page * remove comment + remove old createReaction route * fix quill mentions member search * restore yarn lock file * cleanup * typo * apply feedback * remove ttlcache * fix members scroll bug * fix url * fix collab modal * cleanup * Fix stats middleware (cw.path.called) (#4617) * fix stats middleware * typo * Update yarn.lock. --------- Co-authored-by: Jake Naviasky <[email protected]> * 4121 design thread listing (#4191) * update buttons and component showcase * add margins on secondary and tertiary buttons * isolate new button designs from rest of app * complete button stories; styling improvements * add medium neue haas unica font to buttons * set button type correctly * update styles for thread previews * always display dot in thread preview * create second bell icon so as not to effect current bell icons * fix alignments in thread preview bottom menu * add new arrow icons to thread previews * add new arrow icons for small reaction arrow * re-insert thread preview styling * remove unused files * restore styles * fix bug wherein upvote button did not display * remove unnecessary padding from footer options * remove styling hack from component * downcase label on new tags * center user id text * fix error handling on discord channel fetch (#4622) * always show community allow user set visibility on sidebar * ensure local storage visibility pref correct * remember menu state on other menus * sides in and out instead of just appearing * made desktop sidebar draggable * add desktop platform notifs * Allow toggle on root url --------- Co-authored-by: Alex Young <[email protected]> Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Marcin Maslanka <[email protected]> Co-authored-by: Muon Shot <[email protected]> Co-authored-by: Jake Naviasky <[email protected]> Co-authored-by: Ryan Bennett <[email protected]> Co-authored-by: Malik Zulqurnain <[email protected]> Co-authored-by: Mark Hagelberg <[email protected]> Co-authored-by: Kurtis Assad <[email protected]> Co-authored-by: Ian Rowan <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Malik Zulqurnain <[email protected]> Co-authored-by: Daniel Martins <[email protected]> Co-authored-by: Timothee Legros <[email protected]> Co-authored-by: Alex Young <[email protected]> Co-authored-by: Timothee Legros <[email protected]> Co-authored-by: Ifu Aniemeka <[email protected]>

Marcin Maslanka and others added 30 commits June 28, 2023 17:45

Quill initial work

5cc1a6e

Add monospace font on markdown

3f14273

Add focus styles

1272b22

Add disabled state

28b8148

prevent jump between markdown toggle

d6aa2ef

Adjust quill all over the app

e786f00

Merge remote-tracking branch 'origin/master' into marcin.4122-quill

bc80c5b

Merge remote-tracking branch 'origin/master' into marcin.4122-quill

25c17f3

Update icons to phosphor

de47d97

Add quill to component showcase

5f761c0

Remove placeholder default text

24ee59f

Merge confclits

3abc909

Add banner component

b014112

Add static banner to view thread page

e7f7e91

Add static banner to create thread page

67a0831

Merge remote-tracking branch 'origin/master' into marcin.4380-show-ct…

b2e4e06

…a-banner # Conflicts: # packages/commonwealth/client/scripts/views/pages/view_thread/ViewThreadPage.tsx # packages/commonwealth/static/fonts/fonts.css

Add closing banner in new thread form

aaa6579

Add closing banner in discussion page

d2c23b2

Abstract join community logic into hook

a5f850f

use join community hook in new thread form

2d52ee3

use join community hook in view thread page

0829eaf

use hook for check active account

ac6cbce

use hook for closing banner logic

43ac05e

abstract AccountSelectorModal

01186a8

abstract TOS modal

d408ba7

abstract all join community modals modals

edd9501

rename old banner and create new component for join community banner

c8e2128

Merge remote-tracking branch 'origin/master' into marcin.4380-show-ct…

19da25a

…a-banner

Fix ts errors

d11ca48

Merge branch 'master' into marcin.4380-show-cta-banner

1ee8b4c

Marcin Maslanka added 8 commits July 19, 2023 15:12

Add tooltip wrapper to thread action

4c43c2e

Edit tooltip styles to adjust new designs

8f54461

Add tooltip to disabled buttons

0a7c314

Handle reply button

842e229

Fix create thread buttons

b58a217

Merge remote-tracking branch 'origin/master' into marcin.4378-disable…

09d1686

…-thread-actions # Conflicts: # packages/commonwealth/client/scripts/views/components/ReactionButton/CommentReactionButton.tsx

self CR

ce05cad

fixed lint errors

eb7bcfd

masvelio changed the title ~~WIP - Marcin.4378 disable thread actions~~ Disable thread actions for users that have not joined the community Jul 20, 2023

remove comment

8a198db

masvelio marked this pull request as ready for review July 20, 2023 15:36

masvelio requested review from jnaviask, zakhap, dillchen and CowMuon as code owners July 20, 2023 15:36

Marcin Maslanka added 2 commits July 21, 2023 13:02

Merge remote-tracking branch 'origin/master' into marcin.4378-disable…

6499a97

…-thread-actions # Conflicts: # packages/commonwealth/client/scripts/views/components/ReactionButton/CommentReactionButton.tsx

conflicts

2a146a7

masvelio mentioned this pull request Jul 21, 2023

🪣 First-time community member frictions | Onboarding #4306

Closed

4 tasks

jnaviask approved these changes Jul 24, 2023

View reviewed changes

jnaviask merged commit 708de98 into master Jul 24, 2023
5 checks passed

jnaviask deleted the marcin.4378-disable-thread-actions branch July 24, 2023 16:41

mzparacha mentioned this pull request Jul 24, 2023

Added Skeleton in Discussion + Overview + View Thread page #4295

Merged

masvelio mentioned this pull request Aug 3, 2023

Migrated threads state to react query #4588

Merged

masvelio mentioned this pull request Aug 21, 2023

Session Keys: UX Update to Disable Actions #4317

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable thread actions for users that have not joined the community #4521

Disable thread actions for users that have not joined the community #4521

masvelio commented Jul 18, 2023 •

edited

Loading

jessmart1213 commented Jul 24, 2023

meeshlin commented Jul 25, 2023

Disable thread actions for users that have not joined the community #4521

Disable thread actions for users that have not joined the community #4521

Conversation

masvelio commented Jul 18, 2023 • edited Loading

Link to Issue

Description of Changes

Test Plan

Other Considerations

jessmart1213 commented Jul 24, 2023

meeshlin commented Jul 25, 2023

masvelio commented Jul 18, 2023 •

edited

Loading