Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Keys: UX Update to Disable Actions #4317

Closed
zakhap opened this issue Jun 22, 2023 · 4 comments
Closed

Session Keys: UX Update to Disable Actions #4317

zakhap opened this issue Jun 22, 2023 · 4 comments
Assignees
Labels
3 Full day task blocker This story is BLOCKING another story refinement
Milestone

Comments

@zakhap
Copy link
Collaborator

zakhap commented Jun 22, 2023

User Story

  • As a user, I need to know the actions I can and cannot take when I haven’t joined a community with my current “connected” (primary) address, so I can decide whether I want to switch to an address I already have linked to the community or to join the community.

Solution to Implement:

  • Disable actions for users who’s address haven’t “joined” a community
    • Disable the upvote functionality
    • Disable the comment functionality (should be already done).

This ticket is closely related to #4378.

@zakhap zakhap changed the title Disabled Actions UX Update to Disable Actions Jun 22, 2023
@zakhap zakhap added refinement blocker This story is BLOCKING another story labels Jun 22, 2023
@meeshlin meeshlin self-assigned this Jun 23, 2023
@zakhap zakhap added this to the Session Keys milestone Jul 6, 2023
@CowMuon CowMuon changed the title UX Update to Disable Actions Session Keys: UX Update to Disable Actions Jul 6, 2023
@CowMuon
Copy link
Contributor

CowMuon commented Aug 7, 2023

Some questions here around relations between a linked address and being joined to a community. Just discussed with Jake, sounds like we will need Zak's input to clarify.

@masvelio masvelio added 2 Half day task and removed needs estimate labels Aug 21, 2023
@masvelio
Copy link
Contributor

From my investigation it looks that we only need to disable big upvote button

Image

Blocking other actions has been already done in #4521

@masvelio masvelio added 3 Full day task and removed 2 Half day task labels Aug 21, 2023
@masvelio
Copy link
Contributor

In this ticket I am gonna also take care about displaying revalidation-session-modal properly so it would be the last step before we can move session-keys to the QA (at least from my perspective)

@masvelio
Copy link
Contributor

Work has been pushed to raymond.react-session-keys-on:

  • disabling button 45c0c02
  • moving RevalidationSessionModal to reusable hook and use that hook in multiple places (there are more commits but this is most important) dd8622d

Because we are working on feature-branch, I am closing this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 Full day task blocker This story is BLOCKING another story refinement
Projects
None yet
Development

No branches or pull requests

5 participants