Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip registry login if not publishing to that specific registry #391

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Skip registry login if not publishing to that specific registry #391

merged 1 commit into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. Skip registry login if not publishing to that specific registry 

    When new builder images are published on main, they can be
published to two different registries:
1. The public Docker repo on Docker Hub
2. A private internal registry

Previously we'd always log into both registries, even if that particular
job was only publishing to one of the two registries.

Several of our images are already only published to one of the two
registries, and soon virtually all of them will be (as part of upcoming
PRs to add new image variants) - meaning it makes even more sense
to skip login if it's not needed.
    @edmorley
    edmorley committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    99d001b View commit details
    Browse the repository at this point in the history