Skip registry login if not publishing to that specific registry #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When new builder images are published on main, they can be published to two different registries: 1. The public Docker repo on Docker Hub 2. A private internal registry Previously we'd always log into both registries, even if that particular job was only publishing to one of the two registries. Several of our images are already only published to one of the two registries, and soon virtually all of them will be (as part of upcoming PRs to add new image variants) - meaning it makes even more sense to skip login if it's not needed.
colincasey
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new builder images are published, they can be published to two different registries:
Previously we'd always log into both registries, even if that particular job was only publishing to one of the two registries.
Several of our images are already only published to one of the two registries, and soon virtually all of them will be (as part of upcoming PRs to add new image variants) - meaning it makes even more sense to skip login if it's not needed.
GUS-W-14179420.