-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add formatter schema #56
Conversation
This is needed for flakes that want to support `nix fmt`
Seems to work after suggestions and looks alright.
Yeah the testing situation is kinda bad because I don't want to pollute the repo with test dependencies and such. People complain about those, even in other repos that aren't low level like this one. Not sure if I should wait for something like NixOS/nix#6124 |
Co-authored-by: Robert Hensing <[email protected]>
Co-authored-by: Robert Hensing <[email protected]>
Yeah, I know what you mean. One workaround would be to add a tests/flake.nix that refers back to the root flake. |
Yeah, I'm doing something similar in the |
Oh well :) I think this is ready. I switched the upstream PR to this branch, and it's working as intended. |
This comment was marked as outdated.
This comment was marked as outdated.
56: add formatter schema r=roberth a=zimbatm This is needed for flakes that want to support `nix fmt`. Right now it's missing some testing as I didn't find a test framework for it. Needed by numtide/treefmt#169 Co-authored-by: zimbatm <[email protected]> Co-authored-by: Jonas Chevalier <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
bors r+ |
Build succeeded: |
This is needed for flakes that want to support
nix fmt
.Right now it's missing some testing as I didn't find a test framework for it.
Needed by numtide/treefmt#169