Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U.S. English translation revamp and cleanup of other lang files #736

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

Greg-21
Copy link
Contributor

@Greg-21 Greg-21 commented Sep 9, 2024

First, a quick note that this pull request is technically a draft and will initially be labeled as such here on GitHub, so every single change can be freely discussed without any time pressure.

To simplify the review process, this pull request consists of three main parts (one commit for each part):

  1. U.S. English translation revamp:
    • The focus here was put on rephrasing the sentences used in tooltips and in-game configuration menus in the hope of making them clearer and easier to understand (especially for people who are new to this fantastic mod and don’t know yet what each option does).
    • In addition, standardization of wording also played a significant role here because it happened that the same thing was called differently in different places.
    • Another thing worth noting is a capitalization of slider and button labels, and an addition of dots at the ends of sentences in tooltips for parity with vanilla Minecraft.
    • On top of that, the cloth_config.voicechat.category.other translation key has been renamed to cloth_config.voicechat.category.ingame_menu to better reflect the new value it now conveys.
    • Last but not least, the following two translation keys: message.voicechat.enabled and message.voicechat.disabled have been renamed to message.voicechat.denoiser.on and message.voicechat.denoiser.off respectively to show the logical connection between them and the corresponding configuration option they define (i.e. message.voicechat.denoiser). Additionally, this also replaces the long descriptive labels such as "enabled" and "disabled" with their shorter and generic equivalents: "ON" and "OFF".
  2. Configuration file comment revamp:
    • This mainly introduces the same changes as in the previous point so that not only people using the in-game configuration GUI based on the Cloth Config API could benefit from the improvements but also people configuring this mod directly via configuration files.
    • It also unifies the comments for various configuration options between different platforms/engines so that everyone is treated equally.
  3. Translation file cleanup:
    • This includes rearranging all lines so that they are in the same order as in the source U.S. English translation file, removing translation keys that are no longer in use, and unifying line endings to always use LF only.
    • Most of these changes were made automatically by a script I created, so the chance of error is minimal.

Please review these changes carefully, as the description above only summarizes the most significant ones, not all of them. I'm open to all kinds of criticism and comments because I realize that what seems like a positive change to me, may actually be the opposite. Furthermore, this is your mod, your repo, your rules (not mine), and I'm just trying to help as much as I can.

Copy link
Owner

@henkelmax henkelmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I really appreciate you taking the time to make everything more consistent.
I have a few issues with the descriptions. Mostly periods at the end of sentences and the removal of the If in the configs.
I generally prefer to only capitalize text in titles, not buttons, etc.

Please don't take my comments as offensive. I really appreciate the work :)

@henkelmax henkelmax self-assigned this Sep 9, 2024
@henkelmax henkelmax added enhancement New feature or request translation labels Sep 9, 2024
@Greg-21
Copy link
Contributor Author

Greg-21 commented Sep 12, 2024

I've answered all your questions and addressed any concerns you might have had, I hope. If there's a question with no answer, it means that the answer has already been given elsewhere. (If it is not and I have missed something, please let me know.)

Have a nice day!

@Greg-21 Greg-21 force-pushed the translation-revamp-and-cleanup branch from 393a36d to 434ccb7 Compare September 12, 2024 13:40
@henkelmax
Copy link
Owner

henkelmax commented Sep 12, 2024

I've answered all your questions and addressed any concerns you might have had, I hope. If there's a question with no answer, it means that the answer has already been given elsewhere. (If it is not and I have missed something, please let me know.)

Have a nice day!

I reviewed and answered all your comments :)
Good job btw :) you are really taking the consistency to minecraft serious

@Greg-21
Copy link
Contributor Author

Greg-21 commented Sep 18, 2024

We are getting closer and closer to the final result that both of us can be satisfied with, I hope.

I'm sorry that it's taking so long and that the progress since last time is minimal, but I'm only working on it in my spare time, making just a few changes each day.

@Greg-21 Greg-21 force-pushed the translation-revamp-and-cleanup branch from 434ccb7 to eca085e Compare September 18, 2024 09:50
@henkelmax
Copy link
Owner

We are getting closer and closer to the final result that both of us can be satisfied with, I hope.

I'm sorry that it's taking so long and that the progress since last time is minimal, but I'm only working on it in my spare time, making just a few changes each day.

No worries :)
Let me know once its ready to review.

@Greg-21
Copy link
Contributor Author

Greg-21 commented Sep 18, 2024

I've finished and published everything I had planned for this review cycle earlier today. If you find some time, you can check it out.

@henkelmax
Copy link
Owner

I've finished and published everything I had planned for this review cycle earlier today. If you find some time, you can check it out.

Will do thanks!

@henkelmax
Copy link
Owner

Alright, I think i've answered everything

@ookkoouu ookkoouu mentioned this pull request Sep 22, 2024
@Greg-21
Copy link
Contributor Author

Greg-21 commented Sep 23, 2024

Thank you for your patience. The good news is that there are only a few topics left that need your input.

@henkelmax
Copy link
Owner

Thanks, I think ive answered everything.

@Greg-21
Copy link
Contributor Author

Greg-21 commented Sep 24, 2024

I have a few last review questions for you. Please take a look at them when you find some time.

@henkelmax
Copy link
Owner

I have a few last review questions for you. Please take a look at them when you find some time.

Done

@Greg-21 Greg-21 force-pushed the translation-revamp-and-cleanup branch from d7d19c1 to 2ae5739 Compare September 30, 2024 18:40
@Greg-21
Copy link
Contributor Author

Greg-21 commented Sep 30, 2024

This pull request is now ready for a final review or two. It’s been a long journey, and I really appreciate your help and time!

@Greg-21 Greg-21 marked this pull request as ready for review September 30, 2024 18:41
@Greg-21 Greg-21 requested a review from henkelmax October 2, 2024 09:05
@henkelmax
Copy link
Owner

How do I dismiss a stale review now? ¯_(ツ)_/¯

Just ignore it. I'll do a final pass when I have time and merge it if I don't find anything.

Copy link
Owner

@henkelmax henkelmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except fore some very minor things and something I noticed needs changing in general.

@Greg-21 Greg-21 force-pushed the translation-revamp-and-cleanup branch 3 times, most recently from 270b652 to 330f38d Compare October 6, 2024 10:20
@henkelmax
Copy link
Owner

I found 1 small thing again that I forgot to tell you about, sorry.

@Greg-21 Greg-21 force-pushed the translation-revamp-and-cleanup branch from 330f38d to e6d480a Compare October 8, 2024 14:10
@henkelmax
Copy link
Owner

Thanks a lot!

@henkelmax henkelmax merged commit 3e1ef9b into henkelmax:1.21.1 Oct 8, 2024
@henkelmax
Copy link
Owner

If you have any suggestions or small things that you notice, you can add me on Discord, my name is henkelmax.

henkelmax added a commit that referenced this pull request Oct 8, 2024
henkelmax added a commit that referenced this pull request Oct 8, 2024
henkelmax added a commit that referenced this pull request Oct 8, 2024
henkelmax added a commit that referenced this pull request Oct 8, 2024
henkelmax added a commit that referenced this pull request Oct 8, 2024
@Greg-21
Copy link
Contributor Author

Greg-21 commented Oct 8, 2024

I personally don't use Discord, but thanks for the invitation :)

@Greg-21 Greg-21 deleted the translation-revamp-and-cleanup branch October 8, 2024 15:40
henkelmax added a commit that referenced this pull request Oct 8, 2024
henkelmax added a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants