-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the ping response time message #743
Merged
henkelmax
merged 1 commit into
henkelmax:1.21.3
from
Greg-21:improved-ping-response-message
Oct 27, 2024
Merged
Improved the ping response time message #743
henkelmax
merged 1 commit into
henkelmax:1.21.3
from
Greg-21:improved-ping-response-message
Oct 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greg-21
force-pushed
the
improved-ping-response-message
branch
from
October 22, 2024 21:35
017b6bf
to
e490c6d
Compare
I apologize for the mess, but I haven't done this in a while and needed to refresh my memory on how to do it properly. |
No worries, I could also have merged it in 1.21.1 and then port it to all other versions. |
henkelmax
added a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
pushed a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
added a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
pushed a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
added a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
pushed a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
added a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
pushed a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
added a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
pushed a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
added a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
added a commit
that referenced
this pull request
Oct 27, 2024
henkelmax
added a commit
that referenced
this pull request
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small follow-up to the absolutely massive PR #736 that was recently accepted and merged. It was agreed upon to separate out this small but, unfortunately, breaking change into its own pull request.
The current message that is still in use looks like this: "Got a response after 3 attempts in 150 ms".
Depending on the language and how it is translated, this may suggest that it was the 3 attempts that took 150 ms, and only the fourth attempt was successful without mentioning how long the packet took. If I were to visualize it, it would look something like this: "Got a response (after 3 attempts in 150 ms)". But the intended meaning has always been more like this: "Got a response (after 3 attempts) in 150 ms", meaning that the response took 150 ms, with 3 unsuccessful attempts beforehand.
Therefore, I propose to swap the order of the time in milliseconds it took for the ping to travel back and forth with the number of previous attempts that failed. The new message would look like this: "Got a response in 150 ms after 3 attempts" and would better convey the intended meaning. The only downside is that most of the existing translations now need to be redone.