Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the ping response time message #743

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

Greg-21
Copy link
Contributor

@Greg-21 Greg-21 commented Oct 10, 2024

This is a small follow-up to the absolutely massive PR #736 that was recently accepted and merged. It was agreed upon to separate out this small but, unfortunately, breaking change into its own pull request.

The current message that is still in use looks like this: "Got a response after 3 attempts in 150 ms".

Depending on the language and how it is translated, this may suggest that it was the 3 attempts that took 150 ms, and only the fourth attempt was successful without mentioning how long the packet took. If I were to visualize it, it would look something like this: "Got a response (after 3 attempts in 150 ms)". But the intended meaning has always been more like this: "Got a response (after 3 attempts) in 150 ms", meaning that the response took 150 ms, with 3 unsuccessful attempts beforehand.

Therefore, I propose to swap the order of the time in milliseconds it took for the ping to travel back and forth with the number of previous attempts that failed. The new message would look like this: "Got a response in 150 ms after 3 attempts" and would better convey the intended meaning. The only downside is that most of the existing translations now need to be redone.

@henkelmax henkelmax self-assigned this Oct 10, 2024
@henkelmax henkelmax added enhancement New feature or request translation labels Oct 10, 2024
@Greg-21 Greg-21 changed the base branch from 1.21.1 to 1.21.2 October 22, 2024 21:20
@Greg-21 Greg-21 changed the base branch from 1.21.2 to 1.21.1 October 22, 2024 21:20
@Greg-21 Greg-21 force-pushed the improved-ping-response-message branch from 017b6bf to e490c6d Compare October 22, 2024 21:35
@Greg-21 Greg-21 changed the base branch from 1.21.1 to 1.21.2 October 22, 2024 21:36
@Greg-21
Copy link
Contributor Author

Greg-21 commented Oct 22, 2024

I apologize for the mess, but I haven't done this in a while and needed to refresh my memory on how to do it properly.

@henkelmax
Copy link
Owner

No worries, I could also have merged it in 1.21.1 and then port it to all other versions.

@henkelmax henkelmax changed the base branch from outdated/1.21.2 to 1.21.3 October 23, 2024 16:35
@henkelmax henkelmax merged commit eb2c8b4 into henkelmax:1.21.3 Oct 27, 2024
henkelmax added a commit that referenced this pull request Oct 27, 2024
henkelmax pushed a commit that referenced this pull request Oct 27, 2024
henkelmax added a commit that referenced this pull request Oct 27, 2024
henkelmax pushed a commit that referenced this pull request Oct 27, 2024
henkelmax added a commit that referenced this pull request Oct 27, 2024
henkelmax pushed a commit that referenced this pull request Oct 27, 2024
henkelmax added a commit that referenced this pull request Oct 27, 2024
henkelmax pushed a commit that referenced this pull request Oct 27, 2024
henkelmax added a commit that referenced this pull request Oct 27, 2024
henkelmax pushed a commit that referenced this pull request Oct 27, 2024
henkelmax added a commit that referenced this pull request Oct 27, 2024
henkelmax added a commit that referenced this pull request Oct 27, 2024
henkelmax added a commit that referenced this pull request Oct 27, 2024
@Greg-21 Greg-21 deleted the improved-ping-response-message branch October 27, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants