Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Empty string, booleans, and zero numbers in hcl rendering #3655

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

mutahhir
Copy link
Member

Related issue

Fixes #

Description

In plain English, describe your approach to addressing the issue linked above. For example, if you made a particular design decision, let us know why you chose this path instead of another solution.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir requested a review from a team as a code owner June 17, 2024 10:45
@mutahhir mutahhir requested review from ansgarm and DanielMSchmidt and removed request for a team June 17, 2024 10:46
@mutahhir mutahhir added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 45d55bd Jun 20, 2024
431 checks passed
@mutahhir mutahhir deleted the fix/bug-3621 branch June 20, 2024 13:29
ansgarm added a commit that referenced this pull request Jul 1, 2024
## 0.20.8

### feat

- feat: add validation to TerraformModule
[\#3608](#3608)

### fix

- fix: Empty string, booleans, and zero numbers in hcl rendering
[\#3655](#3655)
- fix: explicitly listen on ipv4 address for verdaccio due to Github
runner image regression
[\#3654](#3654)

### chore

- chore: manifest.json should have stable json
[\#3584](#3584)
- chore: update JSII
[\#3616](#3616)
- chore: remove dependency on jsii-srcmak
[\#3607](#3607)
- chore: Fix a small documentation typo
[\#3629](#3629)
- chore: Use single-label runner for custom-linux-xl
[\#3623](#3623)
- chore: fix branch cleanup
[\#3644](#3644)
- chore: remove Homebrew link and publishing step
[\#3605](#3605)
- chore: Upgrade dependencies for lib
[\#3618](#3618)
- chore: Upgrade dependencies for util
[\#3599](#3599)
- chore: Upgrade dependencies for util
[\#3589](#3589)
- chore: Upgrade dependencies for util
[\#3612](#3612)
- chore: Upgrade dependencies for cli
[\#3613](#3613)
- chore: Upgrade dependencies for cli
[\#3598](#3598)
- chore: Add links and headers
[\#3594](#3594)
- chore(deps): pin trusted workflows based on HashiCorp TSCCR
[\#3614](#3614)
- chore(deps): pin trusted workflows based on HashiCorp TSCCR
[\#3606](#3606)
- chore(deps): pin trusted workflows based on HashiCorp TSCCR
[\#3652](#3652)
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants