-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): support --template urls with file:// protocol #3657
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Hi there! 👋 We haven't heard from you in 60 days and would like to know if you're still working on this or need help. If we don't hear from you before then, I'll auto-close this PR in 30 days. |
Still waiting for comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks like it will work to me.
- You could add a blurb to the documentation: https://github.com/hashicorp/terraform-cdk/blob/main/website/docs/cdktf/create-and-deploy/remote-templates.mdx
- You could also add a test similar to https://github.com/hashicorp/terraform-cdk/blob/main/test/typescript/init-remote-template/test.ts
- Looks like prettier also failed
After some real-life experience with this, what I actually want to do is point it at a template directory. Having the template as a zip committed to the repo is pretty clunky. Also, the way I'm using the In light of this, I would like to change the design to work like this:
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Related issue
Fixes #3656
Description
Update the
--template
flag to supportfile://
URIs for using local template files.Example
Checklist