-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: sessions list pagination #3916
Closed
mikemountain
wants to merge
20
commits into
llb-list-pagination-2
from
mikemountain-sessions-list-pagination
Closed
draft: sessions list pagination #3916
mikemountain
wants to merge
20
commits into
llb-list-pagination-2
from
mikemountain-sessions-list-pagination
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a new foo_deleted table for each subtype of each resource that needs to support pagination. The deleted tables are used to track deletions of resources and return them to users of the new pagination API. We track only the ID and delete_time of the resource, so there's no way to filter out resources that the user could not see before it was deleted. This is intentional to keep the design simple and is not considered a security issue.
github-actions
bot
added
website
core/gen
docs/configuration
core/session
core
core/proto
core/sql
core/daemon
labels
Oct 25, 2023
The Now() method returns the current transaction timestamp.
johanbrandhorst
force-pushed
the
jbrandhorst-target-handler-pagination
branch
from
October 25, 2023 19:56
2b24fdc
to
4e0a096
Compare
mikemountain
force-pushed
the
mikemountain-sessions-list-pagination
branch
from
October 25, 2023 20:54
fbb3f06
to
149e9b2
Compare
johanbrandhorst
force-pushed
the
jbrandhorst-target-handler-pagination
branch
from
October 25, 2023 21:13
4e0a096
to
233ea61
Compare
johanbrandhorst
force-pushed
the
jbrandhorst-target-handler-pagination
branch
from
October 28, 2023 02:46
233ea61
to
72adacd
Compare
The resource type method is used to automatically create refresh tokens from a resource when that resource is the last item returned in a page. This also renames the iam domain ResourceType method to GetResourceType to align with the new method.
The refreshtoken package encapsulates domain logic surrouding the refresh token. A refresh token is used both for paginating through a collection and for requesting any updates to that collection.
The pagination package provides generic functions for iterating over a collection of items such that each incoming request is filled even after filtering is applied.
The purge package contains a job that is used to purge records from the foo_deleted tables when they become older than 30 days.
The new GrantsHash method can be used to track changes to a users grants across requests.
The ListRefreshToken type is used, in its marshalled form, for pagination requests. A new refresh token is returned which each invocation of a list method (unless there was no input refresh token and there were no results).
Helpers for parsing, marshalling and converting types to domain types.
Adds pagination support to the target domain
internal/target: add pagination support
johanbrandhorst
force-pushed
the
jbrandhorst-target-handler-pagination
branch
from
October 30, 2023 17:18
72adacd
to
f327e2b
Compare
johanbrandhorst
force-pushed
the
jbrandhorst-target-handler-pagination
branch
from
October 30, 2023 17:25
f327e2b
to
f98c592
Compare
johanbrandhorst
force-pushed
the
jbrandhorst-target-handler-pagination
branch
from
October 30, 2023 17:37
f98c592
to
9b09518
Compare
The max_page_size variable lets operators control the size of the pagination pages. This value configures both the maximum permitted page size and the default page size when none is explicitly provided. Operators can tweak this option up or down to increase or reduce the load on the database during pagination.
Updates all List endpoints to automatically paginate through results to preserve backwards compatibility. Adding support for user controllable pagination could be considered at a later time.
johanbrandhorst
force-pushed
the
jbrandhorst-target-handler-pagination
branch
from
October 30, 2023 17:45
9b09518
to
5a14945
Compare
mikemountain
force-pushed
the
mikemountain-sessions-list-pagination
branch
from
October 30, 2023 20:02
149e9b2
to
6ab6046
Compare
johanbrandhorst
force-pushed
the
jbrandhorst-target-handler-pagination
branch
from
November 7, 2023 17:54
af7061f
to
85b9651
Compare
Base automatically changed from
jbrandhorst-target-handler-pagination
to
llb-list-pagination-2
November 7, 2023 17:55
johanbrandhorst
force-pushed
the
llb-list-pagination-2
branch
from
November 7, 2023 17:57
2536e7b
to
d7cd665
Compare
johanbrandhorst
force-pushed
the
llb-list-pagination-2
branch
from
November 28, 2023 23:10
47bed5e
to
41f0d82
Compare
johanbrandhorst
force-pushed
the
llb-list-pagination-2
branch
from
December 13, 2023 20:16
604d353
to
e92e8b5
Compare
johanbrandhorst
force-pushed
the
llb-list-pagination-2
branch
from
January 4, 2024 18:48
cf00af5
to
ca69b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.