Skip to content

Commit

Permalink
fixup! handlers/targets: add pagination support
Browse files Browse the repository at this point in the history
  • Loading branch information
johanbrandhorst committed Nov 6, 2023
1 parent 7108059 commit af7061f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions internal/daemon/controller/handlers/targets/target_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,9 @@ func (s Service) ListTargets(ctx context.Context, req *pbs.ListTargetsRequest) (
if err != nil {
return nil, err
}
// TODO: replace the need for this function with some way to convert the `filter`
// to a domain type. This would allow filtering to happen in the domain, and we could
// remove this callback altogether.
filterItemFn := func(ctx context.Context, item target.Target) (bool, error) {
pbItem, err := toProto(ctx, item, newOutputOpts(ctx, item, authResults, authzScopes)...)
if err != nil {
Expand Down

0 comments on commit af7061f

Please sign in to comment.