fixup! handlers/targets: add pagination support

hashicorp · Oct 31, 2023 · 7108059 · 7108059
1 parent 6b77acf
commit 7108059
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/globals/globals.go b/globals/globals.go
@@ -26,6 +26,9 @@ var (
 	// DefaultMaxRequestSize is the maximum size of a request we allow by default
 	DefaultMaxRequestSize = int64(1024 * 1024)
 
+	// DefaultMaxPageSize is the maximum list page size allowed if not set in the config.
+	DefaultMaxPageSize = 1000
+
 	// ContextMaxRequestSizeTypeKey is a value to keep linters from complaining
 	// about clashing string identifiers
 	ContextMaxRequestSizeTypeKey ContextMaxRequestSizeType

diff --git a/internal/daemon/controller/handlers/targets/target_service.go b/internal/daemon/controller/handlers/targets/target_service.go
@@ -55,9 +55,6 @@ import (
 const (
 	credentialDomain = "credential"
 	hostDomain       = "host"
-	// The default max page size is used when one is not
-	// provided to NewService.
-	defaultMaxPageSize = 1000
 )
 
 // extraWorkerFilterFunc takes in a set of workers and returns another set,
@@ -178,7 +175,7 @@ func NewService(
 		return Service{}, errors.New(ctx, errors.InvalidParameter, op, "missing static credential repository")
 	}
 	if maxPageSize == 0 {
-		maxPageSize = uint(defaultMaxPageSize)
+		maxPageSize = uint(globals.DefaultMaxPageSize)
 	}
 	return Service{
 		repoFn:                  repoFn,