Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix headers for individual pages (#76) #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix headers for individual pages (#76) #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pages/connect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { PersonalDetailsContext } from '@utils/contexts';
import { PersonalDetails } from '@utils/types';
import { Footer, Loader, Navbar } from '@shared-components';
import dynamic from 'next/dynamic';
import Head from 'next/head';

type Props = {
personalDetails: PersonalDetails;
Expand All @@ -16,6 +17,10 @@ const ConnectPage = dynamic(() => import('../components/connect/index'), {
const Contact = ({ personalDetails }: Props): JSX.Element => {
return (
<>
<Head>
<title>Harsh Goel | Contact</title>
<meta name="viewport" content="initial-scale=1.0, width=device-width" />
</Head>
<PersonalDetailsContext.Provider value={personalDetails}>
<Navbar />
<ConnectPage />
Expand Down
5 changes: 5 additions & 0 deletions pages/projects.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { getPersonalDetails, getProjectDetails } from '@utils/apiService';
import { PersonalDetailsContext, ProjectDetailsContext } from '@utils/contexts';
import { PersonalDetails, Project } from '@utils/types';
import { Footer, Loader, Navbar, SocialBar } from '@shared-components';
import Head from 'next/head';

const ProjectsPage = dynamic(() => import('../components/projects/index'), {
ssr: false,
Expand All @@ -16,6 +17,10 @@ type Props = {
const Projects = ({ personalDetails, projectDetails }: Props): JSX.Element => {
return (
<>
<Head>
<title>Harsh Goel | Projects</title>
<meta name="viewport" content="initial-scale=1.0, width=device-width" />
</Head>
<PersonalDetailsContext.Provider value={personalDetails}>
<ProjectDetailsContext.Provider value={projectDetails}>
<Navbar />
Expand Down
5 changes: 5 additions & 0 deletions pages/work.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Footer, Loader, Navbar } from '@shared-components';
import { getPersonalDetails, getCompanyDetails } from '@utils/apiService';
import { Company, PersonalDetails } from '@utils/types';
import { CompanyDetailsContext, PersonalDetailsContext } from '@utils/contexts';
import Head from 'next/head';

const WorkPage = dynamic(() => import('../components/work/index'), {
ssr: false,
Expand All @@ -17,6 +18,10 @@ type Props = {
const Work = ({ personalDetails, companyDetails }: Props): JSX.Element => {
return (
<>
<Head>
<title>Harsh Goel | Work</title>
<meta name="viewport" content="initial-scale=1.0, width=device-width" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't need to add this everytime.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you talking about <meta> tag? @harshgoel05

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sorry saw this now :) too late to the party

</Head>
<PersonalDetailsContext.Provider value={personalDetails}>
<CompanyDetailsContext.Provider value={companyDetails}>
<Navbar />
Expand Down