Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix headers for individual pages (#76) #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamyashkhandelwal
Copy link

Description

Added headers for Projects, Work, & Contact page using <Head></Head> from next/head

Fixes # (76)

Test

Hover over to the tab when on Work/Projects/Contact section

@vercel
Copy link

vercel bot commented Sep 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
portfolio-v3 ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 2:14PM (UTC)

@@ -17,6 +18,10 @@ type Props = {
const Work = ({ personalDetails, companyDetails }: Props): JSX.Element => {
return (
<>
<Head>
<title>Harsh Goel | Work</title>
<meta name="viewport" content="initial-scale=1.0, width=device-width" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't need to add this everytime.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you talking about <meta> tag? @harshgoel05

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sorry saw this now :) too late to the party

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants