-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bool filters, add new bool filters, and add createdAt and updatedAt to get_transactions #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @CalvinChanCan , for finding the bug and fixing it.
One small copypasta error I noted, but great otherwise.
monarchmoney/monarchmoney.py
Outdated
variables["filters"]["isSplit"] = is_split | ||
|
||
if imported_from_mint is not None: | ||
variables["filters"]["importedFromMint"] = is_split |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this should be 'imported_from_mint'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks for catching that! Just fixed it.
Will fix #46 |
Thanks all! |
This PR does the following:
Fixes Bool Filter Default Behavior
False
, resulting in unintended filter application. The fix ensures that if bool filters are not provided, the filter is not applied.Introduces Two New Bool Filters
imported_from_mint
andsynced_from_institution
, providing more detail in filtering transactions based on their import source.Transaction Response Enhancements
createdAt
andupdatedAt
fields in the transaction response.Please let me know if there's anything I should change or any feedback. Thanks!