Missing transactions

[emann3]

if MonarchMoney marks a transaction as Recurring, it does not come down as part of the get_transactions function and you have to call get_transactions twice: once with is_recurring=true and once with it as false in order to get all transactions.

Is there a way to make get_transactions NOT filter on recurring if thats what the user wants?

Similar issue on all of the Boolean parameters to get_transactions: has_attachments, has_notes, hidden_from_reports, is_split

But only recurring seems to be something that MonarchMoney sets by itself on a transaction, the rest get downloaded unless I have done something to the transaction, so I can control that.

[grablair]

Hmm, IMO the default get_transactions (i.e. with no filter args) should return all transactions, so this sounds like unintended behavior.

We default to False for a number of filters:

monarchmoney/monarchmoney/monarchmoney.py

Lines 298 to 313 in 6c66ee7

	async def get_transactions(
	self,
	limit: int = 1000,
	offset: Optional[int] = 0,
	start_date: Optional[str] = None,
	end_date: Optional[str] = None,
	search: str = "",
	category_ids: List[str] = [],
	account_ids: List[str] = [],
	tag_ids: List[str] = [],
	has_attachments: bool = False,
	has_notes: bool = False,
	hidden_from_reports: bool = False,
	is_split: bool = False,
	is_recurring: bool = False,
	) -> Dict[str, Any]:

And always add them as filters in the API call variables:

monarchmoney/monarchmoney/monarchmoney.py

Lines 395 to 410 in 6c66ee7

	variables = {
	"offset": offset,
	"limit": limit,
	"orderBy": "date",
	"filters": {
	"search": search,
	"categories": category_ids,
	"accounts": account_ids,
	"tags": tag_ids,
	"hasAttachments": has_attachments,
	"hasNotes": has_notes,
	"hideFromReports": hidden_from_reports,
	"isRecurring": is_recurring,
	"isSplit": is_split,
	},
	}

These should probably be None and then we should not add them as filters in the API call variables if they aren't specified by the user.

[hammem]

This was fixed in #41 and with the v0.1.5 release, it's available in pypi. Just pip install --update monarchmoney to get the latest!