Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tentatively fixes #776 #798

Closed
wants to merge 1 commit into from
Closed

Conversation

correabuscar
Copy link
Contributor

or perhaps there's a better/different way?
#776

@gyscos
Copy link
Owner

gyscos commented Jun 20, 2024

I think we could exit early from these functions if we notice at the start that self.children.is_empty() - there is no need to scroll, and there is no event we could react to.

@correabuscar
Copy link
Contributor Author

I think I avoided early exit via 'if' check to avoid paying the check for every normal non-empty case, which should be most of the cases. At least, that's what I told myself at the time :)

feels kinda hacky either way, maybe I wait for someone else to do it better

@gyscos gyscos reopened this Jun 20, 2024
@gyscos gyscos closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants