Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add navigation menu #692

Merged
merged 23 commits into from
Dec 18, 2023
Merged

feat: add navigation menu #692

merged 23 commits into from
Dec 18, 2023

Conversation

lsantos1873
Copy link
Contributor

@lsantos1873 lsantos1873 commented Sep 26, 2023

JIRA Issue

Description 📄

This PR adds the responsive Navigation Menu component.

⚠️ The component was implemented in typescript, therefore it must be only merged after this PR.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Video

Example from darwin (used for testing)

Screen.Recording.2023-10-04.at.11.44.18.mov

Screenshots 📸

Navigation menu - desktop behavior

Screenshot 2023-10-04 at 11 24 21

Navigation menu - mobile behavior

Example from darwin (used for testing)
Screenshot 2023-10-04 at 11 36 11

Menu subcomponent with an action

image

Switcher subcomponent with actions

image

packages/yoga/src/yoga.d.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@lsantos1873 lsantos1873 changed the title Feat/navigation menu feat: add navigation menu Oct 2, 2023
@lsantos1873 lsantos1873 self-assigned this Oct 4, 2023
@lsantos1873 lsantos1873 force-pushed the feat/navigation-menu branch from 9162977 to a1fa7aa Compare October 4, 2023 10:15
@lsantos1873 lsantos1873 marked this pull request as ready for review October 4, 2023 10:16
@lsantos1873 lsantos1873 force-pushed the feat/navigation-menu branch from 73b3cdb to 888f55a Compare October 4, 2023 15:53
Copy link
Contributor

@MicaelRodrigues MicaelRodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just confirmed building with TS + js still works

@matheushdsbr matheushdsbr merged commit bc394ca into master Dec 18, 2023
3 checks passed
@matheushdsbr matheushdsbr deleted the feat/navigation-menu branch December 18, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants