-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add navigation menu #692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
@gympass/yoga
@gympass/yoga-doc
@gympass/yoga-labnative
labels
Sep 26, 2023
lsantos1873
commented
Sep 26, 2023
lsantos1873
force-pushed
the
feat/navigation-menu
branch
from
October 4, 2023 10:15
9162977
to
a1fa7aa
Compare
lsantos1873
force-pushed
the
feat/navigation-menu
branch
from
October 4, 2023 15:53
73b3cdb
to
888f55a
Compare
MicaelRodrigues
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just confirmed building with TS + js still works
luanlorenzo
approved these changes
Oct 18, 2023
matheushdsbr
requested changes
Oct 31, 2023
18 tasks
lsantos1873
force-pushed
the
feat/navigation-menu
branch
from
December 15, 2023 11:41
7651a64
to
ff292b2
Compare
matheushdsbr
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📄
This PR adds the responsive Navigation Menu component.
Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
[Enter the tips to test this PR]
Checklist: 🔍
Video
Example from darwin (used for testing)
Screen.Recording.2023-10-04.at.11.44.18.mov
Screenshots 📸
Navigation menu - desktop behavior
Navigation menu - mobile behavior
Example from darwin (used for testing)
Menu subcomponent with an action
Switcher subcomponent with actions