fix: console warnings

gympass · Oct 4, 2023 · 888f55a · 888f55a
1 parent 0d4d5ee
commit 888f55a
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 11 deletions.
diff --git a/packages/doc/content/components/components/navigationmenu/index.mdx b/packages/doc/content/components/components/navigationmenu/index.mdx
@@ -106,10 +106,11 @@ render(() => {
         </NavigationMenu.Header>
 
         <NavigationMenu.Items>
-          {itemGroups.map(group => (
-            <NavigationMenu.ItemsGroup>
+          {itemGroups.map((group, index) => (
+            <NavigationMenu.ItemsGroup key={index}>
               {group.map(item => (
                 <NavigationMenu.Item
+                  key={item.label}
                   active={item.active}
                   expanded={item.expanded}
                   icon={<IconComponent icon={item.icon} />}
@@ -121,6 +122,7 @@ render(() => {
                   {item.subitems &&
                     item.subitems.map(({ label }) => (
                       <NavigationMenu.Subitem
+                        key={label}
                         label={label}
                         wrapper={renderWrapper}
                       />
@@ -237,10 +239,11 @@ render(() => {
         </NavigationMenu.Header>
 
         <NavigationMenu.Items>
-          {itemGroups.map(group => (
-            <NavigationMenu.ItemsGroup>
+          {itemGroups.map((group, index) => (
+            <NavigationMenu.ItemsGroup key={index}>
               {group.map(item => (
                 <NavigationMenu.Item
+                  key={item.label}
                   active={item.active}
                   expanded={item.expanded}
                   icon={<IconComponent icon={item.icon} />}
@@ -251,6 +254,7 @@ render(() => {
                   {item.subitems &&
                     item.subitems.map(({ label }) => (
                       <NavigationMenu.Subitem
+                        key={label}
                         label={label}
                         wrapper={renderWrapper}
                       />
@@ -275,6 +279,7 @@ render(() => {
       <NavigationMenu.BottomItems>
         {bottomItems.map(({ active, icon, label, wrapper }) => (
           <NavigationMenu.BottomItem
+            key={label}
             active={active}
             icon={icon}
             label={label}
@@ -342,8 +347,9 @@ render(() => {
         <NavigationMenu.Switcher
           actions={actions}
           avatar={<StyledAvatar fill="vibin" />}
-          title="User"
+          sideOffset={36}
           subtitle="Admin, Supervisor"
+          title="User"
         />
       </NavigationMenu.Footer>
     </NavigationMenu>

diff --git a/packages/yoga/src/NavigationMenu/web/NavigationMenu.test.tsx b/packages/yoga/src/NavigationMenu/web/NavigationMenu.test.tsx
@@ -55,10 +55,11 @@ describe('<NavigationMenu />', () => {
             </NavigationMenu.Header>
 
             <NavigationMenu.Items>
-              {itemGroups.map(group => (
-                <NavigationMenu.ItemsGroup>
+              {itemGroups.map((group, index) => (
+                <NavigationMenu.ItemsGroup key={index}>
                   {group.map(item => (
                     <NavigationMenu.Item
+                      key={item.label}
                       active={item.active}
                       expanded={item.expanded}
                       icon={<IconComponent icon={item.icon} />}
@@ -70,6 +71,7 @@ describe('<NavigationMenu />', () => {
                       {item.subitems &&
                         item.subitems.map(({ label }) => (
                           <NavigationMenu.Subitem
+                            key={label}
                             label={label}
                             wrapper={renderWrapper}
                           />
@@ -134,8 +136,9 @@ describe('<NavigationMenu />', () => {
               <NavigationMenu.Switcher
                 actions={actions}
                 avatar={<Avatar.Circle />}
-                title="User"
+                sideOffset={36}
                 subtitle="Admin, Supervisor"
+                title="User"
               />
             </NavigationMenu.Footer>
           </NavigationMenu>

diff --git a/packages/yoga/src/NavigationMenu/web/Switcher/Actions.tsx b/packages/yoga/src/NavigationMenu/web/Switcher/Actions.tsx
@@ -7,7 +7,7 @@ import * as Styles from './Actions.styles';
 
 type ActionsProps = {
   actions: SwitcherActionsProps[];
-  sideOffset: string;
+  sideOffset: number;
 };
 
 const Actions = ({ actions, sideOffset }: ActionsProps) => {

diff --git a/packages/yoga/src/NavigationMenu/web/Switcher/Switcher.tsx b/packages/yoga/src/NavigationMenu/web/Switcher/Switcher.tsx
@@ -14,7 +14,7 @@ export type SwitcherProps = {
   actions?: SwitcherActionsProps[];
   avatar: React.ReactElement;
   fill?: string;
-  sideOffset?: string;
+  sideOffset?: number;
   subtitle?: string;
   title: string;
 };
@@ -23,7 +23,7 @@ const Switcher = ({
   actions,
   avatar: Avatar,
   fill = 'transparent',
-  sideOffset = '4',
+  sideOffset = 36,
   subtitle,
   title,
 }: SwitcherProps) => {