fix: codacy issues

gympass · Oct 4, 2023 · 0d4d5ee · 0d4d5ee
1 parent 1eb9232
commit 0d4d5ee
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 28 deletions.
diff --git a/packages/doc/content/components/components/navigationmenu/index.mdx b/packages/doc/content/components/components/navigationmenu/index.mdx
@@ -25,9 +25,9 @@ Gympass `<NavigationMenu />` displays a navigation menu with 3 optional main are
 
 `<NavigationMenu.Header />` and `<NavigationMenu.Footer />` are containers that can be used to display components like logos, `<NavigationMenu.Menu />` or `<NavigationMenu.Switcher />`.
 
-`<NavigationMenu.Items />` should be used to display items and subitems.
+`<NavigationMenu.Items />` must be used to display items and subitems.
 
-The menu is responsive by default and controled by props. `<NavigationMenu.BottomItems />` and `<NavigationMenu.BottomItem />` should be used to display the items in the bottom bar.<br /><br />
+The menu is responsive by default and controled by props. `<NavigationMenu.BottomItems />` and `<NavigationMenu.BottomItem />` must be used to display the items in the bottom bar.<br /><br />
 
 Available components:
 

diff --git a/packages/labnative/pages/NavigationMenu.jsx b/packages/labnative/pages/NavigationMenu.jsx
diff --git a/packages/labnative/pages/index.js b/packages/labnative/pages/index.js
@@ -25,7 +25,6 @@ import Banner from './Banner';
 import Heading from './Heading';
 import Skeleton from './Skeleton';
 import ActionRequirement from './ActionRequirement';
-import NavigationMenu from './NavigationMenu';
 
 export {
   Button,
@@ -55,5 +54,4 @@ export {
   Heading,
   Skeleton,
   ActionRequirement,
-  NavigationMenu,
 };
diff --git a/packages/yoga/src/NavigationMenu/index.ts b/packages/yoga/src/NavigationMenu/index.ts
@@ -1 +1,3 @@
-export { default } from './web';
+import WebNavigationMenu from './web';
+
+export default WebNavigationMenu;
diff --git a/packages/yoga/src/NavigationMenu/web/Menu/index.ts b/packages/yoga/src/NavigationMenu/web/Menu/index.ts
@@ -1,3 +1,5 @@
-export { default } from './Menu';
+import Menu from './Menu';
 
 export type { MenuProps } from './Menu';
+
+export default Menu;
diff --git a/packages/yoga/src/NavigationMenu/web/NavigationMenu.test.tsx b/packages/yoga/src/NavigationMenu/web/NavigationMenu.test.tsx
@@ -5,11 +5,20 @@ import { Help, Doc } from '@gympass/yoga-icons';
 
 import NavigationMenu from './NavigationMenu';
 
+type IconProps = {
+  icon: React.ReactElement<typeof Icon>;
+};
+
 describe('<NavigationMenu />', () => {
   describe('Snapshots', () => {
     it('should match  NavigationMenu', () => {
-      const renderWrapper = ({ children }) => <a href="#">{children}</a>;
-      const IconComponent = ({ icon }) => <Icon as={icon} />;
+      const renderWrapper = ({ children }) => {
+        return <a href="https://www.gympass.com">{children}</a>;
+      };
+
+      const IconComponent = ({ icon }: IconProps) => {
+        return <Icon as={icon} />;
+      };
 
       const itemGroups = [
         [
@@ -94,7 +103,7 @@ describe('<NavigationMenu />', () => {
                 avatar={<Avatar.Circle />}
                 title="Company"
                 subtitle="Reseller"
-                onClick={() => alert('Menu was clicked')}
+                onClick={() => null}
               />
             </NavigationMenu.Header>
           </NavigationMenu>
@@ -109,12 +118,12 @@ describe('<NavigationMenu />', () => {
         {
           id: 'Action 1',
           label: 'Action 1',
-          onClick: () => alert('Action 1 was selected'),
+          onClick: () => null,
         },
         {
           id: 'Action 2',
           label: 'Action 2',
-          onClick: () => alert('Action 2 was selected'),
+          onClick: () => null,
         },
       ];
 

diff --git a/packages/yoga/src/NavigationMenu/web/Switcher/index.ts b/packages/yoga/src/NavigationMenu/web/Switcher/index.ts
@@ -1,3 +1,5 @@
-export { default } from './Switcher';
+import Switcher from './Switcher';
 
 export type { SwitcherProps, SwitcherActionsProps } from './Switcher';
+
+export default Switcher;
diff --git a/packages/yoga/src/NavigationMenu/web/__snapshots__/NavigationMenu.test.tsx.snap b/packages/yoga/src/NavigationMenu/web/__snapshots__/NavigationMenu.test.tsx.snap
@@ -481,7 +481,7 @@ exports[`<NavigationMenu /> Snapshots should match  NavigationMenu 1`] = `
           class="c10"
         >
           <a
-            href="#"
+            href="https://www.gympass.com"
           >
             <div
               class="c11 c12"
@@ -510,7 +510,7 @@ exports[`<NavigationMenu /> Snapshots should match  NavigationMenu 1`] = `
           class="c10"
         >
           <a
-            href="#"
+            href="https://www.gympass.com"
           >
             <div
               class="c11 c20"
@@ -528,7 +528,7 @@ exports[`<NavigationMenu /> Snapshots should match  NavigationMenu 1`] = `
           class="c21"
         >
           <a
-            href="#"
+            href="https://www.gympass.com"
           >
             <div
               class="c11 c12"
@@ -556,7 +556,7 @@ exports[`<NavigationMenu /> Snapshots should match  NavigationMenu 1`] = `
           class="c10"
         >
           <a
-            href="#"
+            href="https://www.gympass.com"
           >
             <div
               class="c11 c12"

diff --git a/packages/yoga/src/NavigationMenu/web/index.ts b/packages/yoga/src/NavigationMenu/web/index.ts
@@ -1 +1,3 @@
-export { default } from './NavigationMenu';
+import NavigationMenu from './NavigationMenu';
+
+export default NavigationMenu;