Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin lalsuite version and fix error in pycbc_plot_singles_vs_params #4997

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Pin lalsuite version and fix error in pycbc_plot_singles_vs_params #4997

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
373dc11
Test printing z before it undergoes max()
GarethCabournDavies Dec 19, 2024
cfb98d1
Add output for relevant files needed to recreate job
GarethCabournDavies Dec 19, 2024
7ed83cb
just upload everything for this test
GarethCabournDavies Dec 19, 2024
503488e
Fix
GarethCabournDavies Dec 20, 2024
f37aa71
SEOBNRV4 ROM version has updated
GarethCabournDavies Dec 20, 2024
2446d84
Test blocking latest lalsuite version
GarethCabournDavies Dec 20, 2024
d531484
less than, not block
GarethCabournDavies Dec 20, 2024
7032e92
Adding comment for why this is pinned
GarethCabournDavies Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/basic-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
cd lalsuite-extra
git lfs pull -I "data/lalsimulation/SEOBNRv2ROM_*.dat"
git lfs pull -I "data/lalsimulation/*ChirpTime*.dat"
git lfs pull -I "data/lalsimulation/SEOBNRv4ROM_v2.0.hdf5"
git lfs pull -I "data/lalsimulation/SEOBNRv4ROM_v*.hdf5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this. Looking at the Gitlab repo, that file has not been changed in 8 years (!).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looking deeper in the errors, it seems to be wanting v3.0 of that file, and it doesn't exist that I can see

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact it could be this change that caused the error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, is this on a lalsuite release? How did that slip through??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking the latest lalsuite version is a viable workaround (latest tests), but I know that we generally don't like blocking versions of dependencies.

It is not planned for the required files to be on lalsuite-extra, so we will need to access an alternative.

I think blocking that version for now until the new location is decided, and then we can unblock it once we point to the new location

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning lalsuite to less than this version might be needed temporarily (don't block the release, pin to less than)

mv data/lalsimulation/* ../
cd ../
- name: run pycbc test suite
Expand Down
3 changes: 2 additions & 1 deletion bin/plotting/pycbc_plot_singles_vs_params
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ from matplotlib.colors import LogNorm
from matplotlib.ticker import LogLocator
import h5py
import sys
from packaging.version import Version

import pycbc
import pycbc.pnutils
Expand Down Expand Up @@ -148,7 +149,7 @@ hexbin_style = {

# In earlier versions mpl will try to take the max over bins with 0 triggers
# and fail, unless we tell it to leave these blank by setting mincnt
if matplotlib.__version__ < '3.8.1':
if Version(matplotlib.__version__) < Version('3.8.1'):
hexbin_style['mincnt'] = 0
titodalcanton marked this conversation as resolved.
Show resolved Hide resolved

if opts.log_x:
Expand Down
Loading