Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the check on sigma for FisherSky class more relax (allowing 0 value) #4994

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Making the check on sigma for FisherSky class more relax (allowing 0 value) #4994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12dd166
Making the check on sigma for FisherSky class more relax (allowing 0
Dec 18, 2024
1ca46fd
Changing the error message for sigma check
Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pycbc/distributions/sky_location.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ def __init__(self, **params):
'The mean declination must be between '
f'-π/2 and π/2, {mean_dec} rad given'
)
if sigma <= 0 or sigma > 2 * numpy.pi:
if sigma < 0 or sigma > 2 * numpy.pi:
raise ValueError(
'Sigma must be positive and smaller than 2π '
'Sigma must be non-negative and smaller than 2π '
'(preferably much smaller)'
)
if sigma > 0.35:
Expand Down
Loading