Making the check on sigma for FisherSky class more relax (allowing 0 value) #4994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is allowing 0 values for
sigmain theFisherSkyclass. TheFisherSkyclass follows anumpy.random.rayleighdistribution which allows 0 values forsigma(see this comment)Standard information about the request
This change affects: PyGRB
This change will: allow to use
FisherSkydistribution for GRBs that has asky_errorequals to 0.Motivation
I want to do this PR in order to use PyGRB with GRBs that has a
sky_errorequals to 0 and usesFisherSkyclass as a prior for the right ascension and the declination.