Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warning for no injections #4913

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −0
Open

Adding warning for no injections #4913

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
041599c
Adding warning for no injections
Oct 21, 2024
20e7fc8
Changing where we raised the warning
Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pycbc/inject/inject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,7 @@ def apply(self, strain, detector_name, f_lower=None, distance_scale=1,
# safety buffer
start_time = inj.tc - 2 * (inj_length + 1)
if end_time < t0 or start_time > t1:
logger.warning("No injections applied.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be after the for loop?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion here https://book.pythontips.com/en/latest/for_-_else.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After which loop? If there are no injections, if end_time < t0 or start_time > t1: will be True and the rest of the interaction will be skipped, right? That's why I put the warning in the loop.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's only true for a specific injection. What if the file has multiple things which could be injected? The injection file can have many signals in it (perhaps for different times or even overlapping).

continue
signal = self.make_strain_from_inj_object(inj, delta_t,
detector_name, f_lower=f_l,
Expand Down
Loading