Adding warning for no injections #4913
Conversation
|
@aleynaakyuz I don't think this will do what you think. I think you'd only see a message if the injection-file option wasn't given. I think what you need to do is to add a logging message into the InjectionSet class itself where the injections are applied. |
|
Think about potential changes here. https://github.com/gwastro/pycbc/blob/master/pycbc/inject/inject.py#L561 |
| @@ -568,6 +568,7 @@ def apply(self, strain, detector_name, f_lower=None, distance_scale=1, | |||
| # safety buffer | |||
| start_time = inj.tc - 2 * (inj_length + 1) | |||
| if end_time < t0 or start_time > t1: | |||
| logger.warning("No injections applied.") | |||
There was a problem hiding this comment.
Shouldn't this be after the for loop?
There was a problem hiding this comment.
See discussion here https://book.pythontips.com/en/latest/for_-_else.html
There was a problem hiding this comment.
After which loop? If there are no injections, if end_time < t0 or start_time > t1: will be True and the rest of the interaction will be skipped, right? That's why I put the warning in the loop.
There was a problem hiding this comment.
That's only true for a specific injection. What if the file has multiple things which could be injected? The injection file can have many signals in it (perhaps for different times or even overlapping).
This raises a warning if no injections are applied during an inference job.