Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default run options #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Set default run options #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
755e02d
Set default run options if none are specified
nitomartinez Apr 4, 2020
58495aa
Update README with default options
nitomartinez Apr 30, 2020
32c2b6f
Merge branch 'fix/update_readme' into fix/default_run_options
nitomartinez Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,12 @@ RUN \

FROM alpine:3.9

EXPOSE 22124/udp
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port can be specified from command line. I think it's better to be explicit and expose it from command line.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker documentation states:

The EXPOSE instruction does not actually publish the port. It functions as a type of documentation between the person who builds the image and the person who runs the container, about which ports are intended to be published.

So maybe EXPOSE would make sense, then?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the EXPOSE line here makes it easier to discover which port will be used externally. A good reason to have it here IMO.


RUN apk add --update --no-cache \
qt-x11 icu-libs

COPY --from=builder /usr/local/bin/Jamulus /usr/local/bin/Jamulus
ENTRYPOINT ["Jamulus"]
COPY entrypoint.sh /entrypoint.sh
RUN chmod 755 /entrypoint.sh
ENTRYPOINT ["/entrypoint.sh"]
6 changes: 6 additions & 0 deletions entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/bin/sh
if [ $# -eq 0 ]; then
echo "launching default server"
exec Jamulus -s -n
fi
exec Jamulus "$@"