Set default run options #2
Conversation
|
Could you please update README as well and remove parameters from there and notice they are not required for starting container? |
| @@ -32,8 +32,12 @@ RUN \ | |||
|
|
|||
| FROM alpine:3.9 | |||
|
|
|||
| EXPOSE 22124/udp | |||
There was a problem hiding this comment.
The port can be specified from command line. I think it's better to be explicit and expose it from command line.
There was a problem hiding this comment.
The docker documentation states:
The EXPOSE instruction does not actually publish the port. It functions as a type of documentation between the person who builds the image and the person who runs the container, about which ports are intended to be published.
So maybe EXPOSE would make sense, then?
There was a problem hiding this comment.
Having the EXPOSE line here makes it easier to discover which port will be used externally. A good reason to have it here IMO.
|
Updated README.md |
This sets the default run options. That is run:
Jamulus -s -nif no options are defined.
This should reduce the complexity ;-)