A89: xDS Cluster Metric Label #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
commented
Jan 10, 2025
| to have a different value. This is the case for locality as well, and the last | ||
| pick's value should be used. | ||
|
|
||
| The `grpc.xds.cluster` label will be available on the following per-call |
There was a problem hiding this comment.
@yashykt, Java hard-codes support for locality today. I remember there being a conversation about supporting arbitrary optional labels, and I think we had kicked that can down the road.
I'm envisioning just adding another hard-coded case to the otel module for this.
yashykt
reviewed
Jan 10, 2025
yashykt
approved these changes
Jan 10, 2025
| ## Implementation | ||
|
|
||
| @ejona86 will immediately implement in gRPC Java. Other languages will follow as | ||
| able. The implementation is very quick. |
There was a problem hiding this comment.
"The implementation is very quick" is more rationale than blueprint.
There was a problem hiding this comment.
It is an answer to "where are the resources coming from." "It is quick, so doesn't need a ton of planning."
I changed the link name so I wouldn't have to specify the link name, and then forgot to remove the link name.
markdroth
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.