-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design): create select component #2458
base: develop
Are you sure you want to change the base?
Conversation
221d199
to
c70cef7
Compare
So does the dropdown track the selected state or is that the responsibility of the consuming component? |
@damienwebdev any input on this? |
@xelaint we discussed this on a call, the component implementation will change significantly. You will probably have some styling to do after |
0b72f99
to
2d49c3f
Compare
@xelaint this is ready for you to do some styling and fix skeleton. I haven't touched keyboard navigation or accessbility yet |
4beb789
to
c3e4b07
Compare
libs/design/src/molecules/select/selected-option/selected-option.directive.ts
Outdated
Show resolved
Hide resolved
libs/design/select/examples/src/default-select/default-select.component.html
Outdated
Show resolved
Hide resolved
libs/design/select/examples/src/default-select/default-select.component.html
Outdated
Show resolved
Hide resolved
How does this component actually handle errors aside from having the |
6426d5f
to
0dc3e10
Compare
TODO: An opened select should not be tabbable. Tab event needs to be blocked so focus is not lost on select. @griest024 |
0dc3e10
to
f63bc55
Compare
done |
6ffeb37
to
2c89fa8
Compare
@griest024 There's a weird scrolling behavior if I open the select using Alt + Down key. https://www.loom.com/share/3123202d6ece417f8d2bc4a3e18af75a?sid=2c2c9540-2563-48c8-85ff-1e4d87203151 |
21fddef
to
a924be7
Compare
This needs a rebase against develop. |
To do for me: fix conflict, rebase against develop, convert to standalone |
also move some fields to private
…es, add/update examples
a924be7
to
0d2cfcf
Compare
fb6b57b
to
47fe584
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no dropdown components.
Things that need to be added:
DaffSelect
Fixes: #2467
What is the new behavior?
A dropdown component that displays a list of options.
Does this PR introduce a breaking change?
Other information