Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14] release: Always use latest changelog tool #47313

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[v14] release: Always use latest changelog tool #47313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d754dac
release: Always use latest changelog tool
camscale Oct 7, 2024
fb0408e
fixup! release: Always use latest changelog tool
camscale Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,13 +705,6 @@ $(RERUN): $(wildcard $(TOOLINGDIR)/cmd/rerun/*.go)
RELEASE_NOTES_GEN := $(TOOLINGDIR)/bin/release-notes
$(RELEASE_NOTES_GEN): $(wildcard $(TOOLINGDIR)/cmd/release-notes/*.go)
cd $(TOOLINGDIR) && go build -o "$@" ./cmd/release-notes
#
# Downloads and builds changelog from source.
# PHONY is set so that we rely on Go's mod cache and not Make's cache.
#
CHANGELOG := $(TOOLINGDIR)/bin/changelog
$(CHANGELOG):
GOBIN=$(TOOLINGDIR)/bin go install github.com/gravitational/shared-workflows/tools/[email protected]

.PHONY: tooling
tooling: ensure-gotestsum $(DIFF_TEST)
Expand Down Expand Up @@ -1593,14 +1586,15 @@ rustup-install-target-toolchain:
# changelog generates PR changelog between the provided base tag and the tip of
# the specified branch.
#
# usage: make -s changelog
# usage: make -s changelog BASE_BRANCH=branch/v13 BASE_TAG=13.2.0
# usage: BASE_BRANCH=branch/v13 BASE_TAG=13.2.0 make -s changelog
# usage: make changelog
# usage: make changelog BASE_BRANCH=branch/v13 BASE_TAG=v13.2.0
# usage: BASE_BRANCH=branch/v13 BASE_TAG=v13.2.0 make changelog
#
# BASE_BRANCH and BASE_TAG will be automatically determined if not specified.
CHANGELOG = github.com/gravitational/shared-workflows/tools/changelog@latest
.PHONY: changelog
changelog: $(CHANGELOG)
$(CHANGELOG) --base-branch="$(BASE_BRANCH)" --base-tag="$(BASE_TAG)" ./
changelog:
@go run $(CHANGELOG) --base-branch="$(BASE_BRANCH)" --base-tag="$(BASE_TAG)" ./

# create-github-release will generate release notes from the CHANGELOG.md and will
# create release notes from them.
Expand Down
Loading