[v14] release: Always use latest changelog tool #47313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `@latest` when running the changelog tool so we do not have to keep bumping the version (and backporting that version bump to the release branches) when we update the tool. Invoke the tool directly with `go run` instead of first installing it with `go install` mostly because it's simpler, but also because the installed tool never gets cleaned up (and due to a missing `.PHONY`, it would stick to an old version). Always run the changelog tool silently (using `@` with make) so we can easily redirect the output of the tool to a file without needing to clean the `make` output. One can easily run `make -n changelog` to see the command being invoked if necessary.
camscale
added
the
no-changelog
tigrato
approved these changes
Oct 8, 2024
r0mant
approved these changes
Oct 8, 2024
public-teleport-github-review-bot
bot
removed the request for review
from doggydogworld
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
@latestwhen running the changelog tool so we do not have to keepbumping the version (and backporting that version bump to the release
branches) when we update the tool.
Invoke the tool directly with
go runinstead of first installing itwith
go installmostly because it's simpler, but also because theinstalled tool never gets cleaned up (and due to a missing
.PHONY, itwould stick to an old version).
Always run the changelog tool silently (using
@with make) so we caneasily redirect the output of the tool to a file without needing to
clean the
makeoutput. One can easily runmake -n changelogto seethe command being invoked if necessary.
Backport: #47260