Refactor DSL code #169
Merged
Refactor DSL code #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding type annotations Replace selections generator by get_ast_fields function Remove ast property Replace serialize_list method by a lambda Remove obsolete test_nested_input_with_old_get_arg_serializer test
Move get_arg_serializer function inside the DSLField class Rename get_field method of DSLType to _get_field
DSLSchema now requires a schema instead of a client query and mutate methods of DSLSchema have been replaced by a gql method which will return a DocumentNode
Set get_ast_field as a staticmethod of the DSLField class
Move DSLSchema.gql method out of the class to the dsl_gql funciton Add a test_multiple_queries test
Put the _get_field method of DSLType inside __getattr__
The GraphQL type is saved in each DSLField This allows us to compute the operation directly from the fields (no need for the operation argument anymore) In dsl_gql, we check that all the fields have the correct type and that they are root fields (Query, Mutation and Subscription) Add new AttributeError for types which are not in the schema Replacing the KeyError by an AttributeError in the __getattr__ method of DSLType Adding debug log messages when creating fields and types
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 939 946 +7
=========================================
+ Hits 939 946 +7
Continue to review full report at Codecov.
|
|
I'll add documentation tomorrow before merging |
Rename known_serializers to known_arg_serializers
Added __repr__ dunder methods to DSLType and DSLField Added debug logs
KingDarBoja
reviewed
Nov 8, 2020
KingDarBoja
reviewed
Nov 8, 2020
KingDarBoja
reviewed
Nov 8, 2020
KingDarBoja
reviewed
Nov 8, 2020
There was a problem hiding this comment.
Outstanding work @leszekhanusz
Also it seems you also fixed #104, right?
Adding executable examples for async and sync clients Added to README.md features
Thanks 😄
No, this is not related, #104 is not using the DSL module at all. |
KingDarBoja
reviewed
Nov 8, 2020
KingDarBoja
approved these changes
Nov 8, 2020
Cito
reviewed
Nov 11, 2020
Cito
reviewed
Nov 11, 2020
Cito
reviewed
Nov 11, 2020
|
I can't believe it 🤦♂️ , the |
KingDarBoja
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the DSL code.
dsl_gqlfunction to convert the DSL operations into a DocumentSimple example: