Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability and Self-contained-ness of DSL module in v2.x #282

Closed
Datoclement opened this issue Dec 12, 2021 · 1 comment
Closed

Usability and Self-contained-ness of DSL module in v2.x #282

Datoclement opened this issue Dec 12, 2021 · 1 comment
Labels
type: question or discussion Issue discussing or asking a question about gql

Comments

@Datoclement
Copy link

Datoclement commented Dec 12, 2021

(Not sure this is a place to ask these kinds of questions)

My current project with Graphene needs graphql-core==2.3.2 and therefore I can only use v2.x of gql library. I would like to use the dynamic query construction in dsl module. I am not sure whether this part of functionality is self-contained in v2.x. I tried to find doc for v2.x but cannot find it. And unlike other functionality, there is neither demo code on dsl in v2.x.

My question is: Is dsl a completed feature in v2.x?

Edit: I am currently looking at the v3 doc to try to understand dsl in v2 (I suppose they would be similar?) but I want to be sure that the code is at least tested and avoid unexpected behaviors.

@leszekhanusz
Copy link
Collaborator

leszekhanusz commented Dec 12, 2021

V2.x is not maintained anymore.

At some point, there was a small example in the README.md

There was a lot of modifications in the DSL code since then:

There were also a few bugs fixed:

If you don't need those features and don't have recursive input objects, then it should work correctly.

@leszekhanusz leszekhanusz added the type: question or discussion Issue discussing or asking a question about gql label Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question or discussion Issue discussing or asking a question about gql
Projects
None yet
Development

No branches or pull requests

2 participants