Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Support node v22 and v23 #2207

Merged
merged 4 commits into from
Jan 17, 2025
Merged

feat(cli): Support node v22 and v23 #2207

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fe3e2b
feat(cli): Support node v22 and v23
spotandjake Nov 21, 2024
9d3ccad
chore: Invert logic
spotandjake Dec 29, 2024
ea106db
Chore: Update cli/bin/grainrun.js
spotandjake Jan 17, 2025
060f3b0
Chore: Update cli/bin/grainrun.js
spotandjake Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cli/bin/grainrun.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,13 @@ const v8 = require("v8");
*
* This seems to work for our needs with Node 18, but we should be cautious when updating.
spotandjake marked this conversation as resolved.
Show resolved Hide resolved
*/
v8.setFlagsFromString("--experimental-wasm-return-call");
if (
process.versions.node.startsWith("18.") ||
process.versions.node.startsWith("19.") ||
process.versions.node.startsWith("20.") ||
process.versions.node.startsWith("21.")
)
spotandjake marked this conversation as resolved.
Show resolved Hide resolved
v8.setFlagsFromString("--experimental-wasm-return-call");

const { readFile } = require("fs/promises");
const { WASI } = require("wasi");
Expand Down
Loading