feat(cli): Support node v22 and v23 #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
peblair,
phated,
alex-snezhko and
marcusroberts
as code owners
spotandjake
force-pushed
the
spotandjake-node-v23
branch
from
c08ec7d to
58e803c
Compare
|
I would reverse the logic and only apply the flag for versions of Node that support it. |
I flipped that logic, I just did a manual check for |
spotandjake
force-pushed
the
spotandjake-node-v23
branch
from
a7fd85a to
9d3ccad
Compare
ospencer
reviewed
Jan 17, 2025
Co-authored-by: Oscar Spencer <[email protected]>
ospencer
reviewed
Jan 17, 2025
Co-authored-by: Oscar Spencer <[email protected]>
ospencer
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the best title for this but before if you tried to run the grain cli with node
v22or above it would error because the--experimental-wasm-return-callflag was used, this just checks if we are on those versions and doesn't apply the flag as the behaviour is the default.I think this pr might be controversial the goal here isn't to change the version of js we use with the pkg binaries just to allow newer versions of node to be used when you've built the compiler from source.