Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix configure-hash-rings.md there is a switch of value for cluster-label-verification-disabled #9486

Closed
wants to merge 1 commit into from
Closed

fix configure-hash-rings.md there is a switch of value for cluster-label-verification-disabled #9486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/sources/mimir/configure/configure-hash-rings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ Any traffic that does not match that prefix is discarded, to ensure that only th
This label must be the same on all instances that are part of the same cluster.
For example, if you run a Grafana Mimir cluster in a dedicated namespace, then set the cluster label to the name of the namespace.
4. **Wait** until the configuration change has been rolled out to all Grafana Mimir instances.
5. Enable cluster label verification on all clusters instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=true`.
5. Enable cluster label verification on all clusters instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=false`.
Copy link
Member

@pstibrany pstibrany Oct 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step ENABLES cluster label verification by REMOVING existing -memberlist.cluster-label-verification-disabled=true option. (After removal, default value will be used, which is false).

(That is, suggested edit is currently wrong).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. Enable cluster label verification on all clusters instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=false`.
5. Enable cluster label verification on all cluster instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=false`.

6. **Wait** until the configuration change has been rolled out to all Grafana Mimir instances.

### Fine tuning memberlist changes propagation latency
Expand Down
Loading