fix configure-hash-rings.md there is a switch of value for cluster-label-verification-disabled #9486
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-verification-disabled > 5. Enable cluster label verification on all clusters instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=true`. Need to be false if we want to enable cluster-label-verification-disabled : > 5. Enable cluster label verification on all clusters instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=false`.
|
|
pstibrany
reviewed
Oct 1, 2024
| @@ -108,7 +108,7 @@ Any traffic that does not match that prefix is discarded, to ensure that only th | |||
| This label must be the same on all instances that are part of the same cluster. | |||
| For example, if you run a Grafana Mimir cluster in a dedicated namespace, then set the cluster label to the name of the namespace. | |||
| 4. **Wait** until the configuration change has been rolled out to all Grafana Mimir instances. | |||
| 5. Enable cluster label verification on all clusters instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=true`. | |||
| 5. Enable cluster label verification on all clusters instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=false`. | |||
There was a problem hiding this comment.
This step ENABLES cluster label verification by REMOVING existing -memberlist.cluster-label-verification-disabled=true option. (After removal, default value will be used, which is false).
(That is, suggested edit is currently wrong).
tacole02
approved these changes
Oct 1, 2024
| @@ -108,7 +108,7 @@ Any traffic that does not match that prefix is discarded, to ensure that only th | |||
| This label must be the same on all instances that are part of the same cluster. | |||
| For example, if you run a Grafana Mimir cluster in a dedicated namespace, then set the cluster label to the name of the namespace. | |||
| 4. **Wait** until the configuration change has been rolled out to all Grafana Mimir instances. | |||
| 5. Enable cluster label verification on all clusters instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=true`. | |||
| 5. Enable cluster label verification on all clusters instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=false`. | |||
There was a problem hiding this comment.
Suggested change
| 5. Enable cluster label verification on all clusters instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=false`. | |
| 5. Enable cluster label verification on all cluster instances by removing the configuration option `-memberlist.cluster-label-verification-disabled=false`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to be false if we want to enable cluster-label-verification :
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.