Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set compactor memory limits #11970

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Set compactor memory limits #11970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b80f3f3
set compactor memory limits
MasslessParticle Feb 15, 2024
00f3097
Merge branch 'main' into tpatterson/compactor-resource-limtis
MasslessParticle Feb 15, 2024
b4599d9
reduce memory limit to something sensible
MasslessParticle Feb 16, 2024
10b286b
Merge branch 'main' into tpatterson/compactor-resource-limtis
MasslessParticle Feb 16, 2024
1f17ea2
changelog
MasslessParticle Feb 16, 2024
5f55e24
Merge branch 'main' into tpatterson/compactor-resource-limtis
MasslessParticle Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
* [11499](https://github.com/grafana/loki/pull/11284) **jmichalek132** Config: Adds `frontend.log-query-request-headers` to enable logging of request headers in query logs.
* [11817](https://github.com/grafana/loki/pull/11817) **ashwanthgoli** Ruler: Add support for filtering results of `/prometheus/api/v1/rules` endpoint by rule_name, rule_group, file and type.
* [11897](https://github.com/grafana/loki/pull/11897) **ashwanthgoli** Metadata: Introduces a separate split interval of `split_recent_metadata_queries_by_interval` for `recent_metadata_query_window` to help with caching recent metadata query results.
* [11970](https://github.com/grafana/loki/pull/11897) **masslessparticle** Ksonnet: Introduces memory limits to the compactor configuration to avoid unbounded memory usage.

##### Fixes
* [11074](https://github.com/grafana/loki/pull/11074) **hainenber** Fix panic in lambda-promtail due to mishandling of empty DROP_LABELS env var.
Expand Down
1 change: 1 addition & 0 deletions production/ksonnet/loki/shipper.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
container.mixin.readinessProbe.httpGet.withPort($._config.http_listen_port) +
container.mixin.readinessProbe.withTimeoutSeconds(1) +
k.util.resourcesRequests('4', '2Gi') +
k.util.resourcesLimits(null, '4Gi') +
container.withEnvMixin($._config.commonEnvs)
else {},

Expand Down
Loading