Set compactor memory limits #11970
Merged
Set compactor memory limits #11970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to add some further detail here, the compactor is being evicted (first |
| @@ -62,6 +62,7 @@ | |||
| container.mixin.readinessProbe.httpGet.withPort($._config.http_listen_port) + | |||
| container.mixin.readinessProbe.withTimeoutSeconds(1) + | |||
| k.util.resourcesRequests('4', '2Gi') + | |||
| k.util.resourcesLimits(null, '32Gi') + | |||
There was a problem hiding this comment.
I'd suggest setting this 2x requests, and adding a note in the release notes for folks to set this limit to a figure appropriate for their env.
32Gi may not be appropriate in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If compactor memory grows unbounded, the underlying node may issue a
SIGTERMto stop in. In this case, the pod doesn't come back up and cluster performance is impacted.This PR introduces a memory limit to the compactor so it'll OOM and be restarted by k8s