Re-pin Bikeshed version to make build-validate-publish work #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should unbreak the build for now (but publishing will still be broken) speced/bikeshed#3012 We can make build-validate-publish required for PRs, and make publish-TR-webgpu and publish-TR-wgsl optional.
|
build-validate-publish is still failing, but likely just becaues the changes don't take effect until this lands on main? I'm not sure how it works. PTAL |
|
@kainino0x thank you very much, it makes sense. Is it possible for bikeshed update to change package version? Otherwise looks good |
I believe it only updates the cross-reference database, not bikeshed itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should unbreak the
build-validate-publishbuild for now (but publishing to TR will still be broken). speced/bikeshed#3012We can make
build-validate-publishrequired for PRs, and makepublish-TR-webgpuandpublish-TR-wgsloptional.