Fix API spec build errors #5050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetoguzderin
added
the
copyediting
|
Seems like the changes made this PR's CI run go green w/o issues. Thank you in advance. |
|
Previews, as seen when this build job started (e65aae5): |
|
Oops, just noticed that this loses highlight to the original argument itself since resulting HTML does not have the |
|
I disabled requiring the API spec to build, to unblock PRs. However I just had another idea, maybe we should re-enable pinning bikeshed to a particular release for EDIT: see #5051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the remaining errors in the API spec. The
|var|style for arguments causes Bikeshed to complaint, so instead the initial defintions are plainvar, and the once used variables are added to ignore at the top rather than going<var>path. If there's any way to make the changes better for long-term maintenance, I'd be glad for your review(s). In case this PR fixes the build issue, it might be good to re-enforce the branch protections to be strict.