-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argumentdef can no longer define a variable (>= 5.0.0) #3012
Comments
Ah, that looks like an unintentional regression. I can run the parser over those bits. Tho, what is the value of marking that as a |
It's kind of awkwardly displayed but it's used in the next block (the red one below the green one). It's also awkward because it's not possible to click on a var that's also a dfn, but once you find one of the other usages, it's possible to highlight them. |
BTW this is breaking our build checks in WebGPU because spec-prod always uses the latest Bikeshed. Do you think you'll be able to fix this soon, or should we put in a workaround (e.g. remove all the inline vars gpuweb/gpuweb#5050 cc @mehmetoguzderin) |
Should unbreak the build for now (but publishing will still be broken) speced/bikeshed#3012 We can make build-validate-publish required for PRs, and make publish-TR-webgpu and publish-TR-wgsl optional.
Should unbreak the build for now (but publishing will still be broken) speced/bikeshed#3012 We can make build-validate-publish required for PRs, and make publish-TR-webgpu and publish-TR-wgsl optional.
In WebGPU we use this pattern to define a variable and an argumentdef entry at the same time:
This doesn't work anymore with Bikeshed 5.0.0:
Should Bikeshed support this or should we find an alternate pattern for WebGPU? (I like argumentdef because it shows optional/nullable, but otherwise would be perfectly happy to use
<dl dfn-type=argument>
.)The text was updated successfully, but these errors were encountered: