[fontbe] pass explicit axis_count when constructing Gvar #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #815 Untested as it requires googlefonts/fontations#919 (and write-fonts dependency bump) to work...
cmyr
reviewed
May 30, 2024
Comment on lines
+58
to
+62
| // in the unlikely event that we have more than 65535 axes... | ||
| .map_err(|_| Error::OutOfBounds { | ||
| what: "axis count".into(), | ||
| value: axis_order.len().to_string(), | ||
| })?; |
There was a problem hiding this comment.
I would personally unwrap here, since I can't imagine this being possible for any conceivable font, but 🤷
There was a problem hiding this comment.
just wait a few years :)
There was a problem hiding this comment.
I strongly prefer Result unless it can't happen. Rationale: if we unwrap all the things that shouldn't happen but plausibly can then it's all but assured we'll hit some of them in production and rue the day we didn't use Result.
anthrotype
force-pushed
the
fontbe-explicit-gvar-axis-count
branch
from
f3c7154
to
9fc1180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #815
CI will be 🔴 until googlefonts/fontations#919 is merged write-fonts dependency bumped