Add test compiling VF with empty gvar

googlefonts · May 30, 2024 · f3c7154 · f3c7154
1 parent 8228814
commit f3c7154
Show file tree

Hide file tree

Showing 10 changed files with 143 additions and 0 deletions.
diff --git a/fontc/src/lib.rs b/fontc/src/lib.rs
@@ -2924,4 +2924,28 @@ mod tests {
                 .collect::<Vec<_>>()
         );
     }
+
+    #[test]
+    fn compile_empty_gvar_with_correct_axis_count() {
+        // The test font contains a 'wght' axis and only 1 UFO source with a variable
+        // FEA that varies the position of glyph 'A' based on the wght axis; the gvar
+        // actually contains no glyph variations. Taken from
+        // https://github.com/googlefonts/fontc/issues/815
+        let result = TestCompile::compile_source("varpos.designspace");
+        let font = result.font();
+
+        let fvar = font.fvar().unwrap();
+        let gvar = font.gvar().unwrap();
+
+        // We assert that axis_count matches fvar's despite the gvar being no-op
+        // (i.e. all glyph variations are empty)
+        assert_eq!(fvar.axis_count(), 1);
+        assert_eq!(fvar.axis_count(), gvar.axis_count());
+        let glyph_count = font.maxp().unwrap().num_glyphs();
+        assert_eq!(gvar.glyph_count(), glyph_count);
+        assert!((0..glyph_count).all(|gid| gvar
+            .glyph_variation_data(GlyphId::new(gid as u16))
+            // read-fonts would return an error when a glyph's variations are empty
+            .is_err()));
+    }
 }
diff --git a/resources/testdata/varpos.designspace b/resources/testdata/varpos.designspace
@@ -0,0 +1,13 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<designspace format="5.0">
+  <axes>
+    <axis tag="wght" name="weight" minimum="100" maximum="900" default="400"/>
+  </axes>
+  <sources>
+    <source filename="varpos_Regular.ufo" stylename="Regular">
+      <location>
+        <dimension name="weight" xvalue="400"/>
+      </location>
+    </source>
+  </sources>
+</designspace>
diff --git a/resources/testdata/varpos_Regular.ufo/features.fea b/resources/testdata/varpos_Regular.ufo/features.fea
@@ -0,0 +1,3 @@
+feature test {
+    pos A <100 0 (wght=400:200 wght=900:400) 0>;
+} test;
diff --git a/resources/testdata/varpos_Regular.ufo/fontinfo.plist b/resources/testdata/varpos_Regular.ufo/fontinfo.plist
@@ -0,0 +1,30 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+  <dict>
+    <key>ascender</key>
+    <integer>750</integer>
+    <key>capHeight</key>
+    <integer>750</integer>
+    <key>descender</key>
+    <integer>-250</integer>
+    <key>guidelines</key>
+    <array/>
+    <key>postscriptBlueValues</key>
+    <array/>
+    <key>postscriptFamilyBlues</key>
+    <array/>
+    <key>postscriptFamilyOtherBlues</key>
+    <array/>
+    <key>postscriptOtherBlues</key>
+    <array/>
+    <key>postscriptStemSnapH</key>
+    <array/>
+    <key>postscriptStemSnapV</key>
+    <array/>
+    <key>unitsPerEm</key>
+    <integer>1000</integer>
+    <key>xHeight</key>
+    <integer>500</integer>
+  </dict>
+</plist>
diff --git a/resources/testdata/varpos_Regular.ufo/glyphs/A_.glif b/resources/testdata/varpos_Regular.ufo/glyphs/A_.glif
@@ -0,0 +1,27 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<glyph name="A" format="2">
+  <advance width="500"/>
+  <unicode hex="0041"/>
+  <outline>
+    <contour>
+      <point x="0" y="500" type="line"/>
+      <point x="0" y="0" type="line"/>
+      <point x="500" y="0" type="line"/>
+      <point x="500" y="500" type="line"/>
+    </contour>
+  </outline>
+  <lib>
+    <dict>
+      <key>xyz.fontra.layer-names</key>
+      <dict>
+        <key>varpos_Regular/public.default</key>
+        <string>&lt;default&gt;</string>
+      </dict>
+      <key>xyz.fontra.source-names</key>
+      <dict>
+        <key>Regular</key>
+        <string>&lt;default&gt;</string>
+      </dict>
+    </dict>
+  </lib>
+</glyph>
diff --git a/resources/testdata/varpos_Regular.ufo/glyphs/contents.plist b/resources/testdata/varpos_Regular.ufo/glyphs/contents.plist
@@ -0,0 +1,8 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+  <dict>
+    <key>A</key>
+    <string>A_.glif</string>
+  </dict>
+</plist>
diff --git a/resources/testdata/varpos_Regular.ufo/glyphs/layerinfo.plist b/resources/testdata/varpos_Regular.ufo/glyphs/layerinfo.plist
@@ -0,0 +1,8 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+  <dict>
+    <key>color</key>
+    <string>0.5,0,0.5,0.7</string>
+  </dict>
+</plist>
diff --git a/resources/testdata/varpos_Regular.ufo/layercontents.plist b/resources/testdata/varpos_Regular.ufo/layercontents.plist
@@ -0,0 +1,10 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+  <array>
+    <array>
+      <string>public.default</string>
+      <string>glyphs</string>
+    </array>
+  </array>
+</plist>
diff --git a/resources/testdata/varpos_Regular.ufo/lib.plist b/resources/testdata/varpos_Regular.ufo/lib.plist
@@ -0,0 +1,10 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+  <dict>
+    <key>public.glyphOrder</key>
+    <array>
+      <string>A</string>
+    </array>
+  </dict>
+</plist>
diff --git a/resources/testdata/varpos_Regular.ufo/metainfo.plist b/resources/testdata/varpos_Regular.ufo/metainfo.plist
@@ -0,0 +1,10 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+  <dict>
+    <key>creator</key>
+    <string>com.github.fonttools.ufoLib</string>
+    <key>formatVersion</key>
+    <integer>3</integer>
+  </dict>
+</plist>