Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI to expose build instability #656

Merged
merged 8 commits into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions .github/workflows/gsbuild.yml

This file was deleted.

66 changes: 66 additions & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,4 +163,70 @@ jobs:
- name: cargo test fea-rs
run: cargo test -p fea-rs

# Check if GS builds, builds repeatably, and passes OTS
# https://github.com/googlefonts/fontc/issues/647
build-gs-repeatably:
rsheeter marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
name: Build GS and check the result
steps:
- name: Check out fontc source repository
uses: actions/checkout@v4

- name: Install the latest stable Rust toolchain
uses: dtolnay/rust-toolchain@stable

- name: Build and install fontc (release mode)
run: cd fontc && pwd && cargo install --path .

- name: Check out font project source repository
uses: actions/checkout@v4
with:
repository: googlefonts/googlesans
token: ${{ secrets.GS_READ_FONTC }}

- name: Pin SOURCE_DATE_EPOCH
run: echo "SOURCE_DATE_EPOCH=$(date +%s)" >> "$GITHUB_ENV"

- name: Compile me once, shame on you
run: |
rm -rf build
fontc source/GoogleSans/GoogleSans.designspace
cp build/font.ttf ./first-roman.ttf
rm -rf build
fontc source/GoogleSans/GoogleSans-Italic.designspace
cp build/font.ttf ./first-italic.ttf

- name: Fetch OTS
run: |
curl -OL "https://github.com/khaledhosny/ots/releases/download/v9.1.0/ots-9.1.0-Linux.zip"
unzip "ots-9.1.0-Linux.zip" "ots-9.1.0-Linux/ots-sanitize"

- name: OTS tests, Roman
run: ots-9.1.0-Linux/ots-sanitize build/font.ttf

- name: OTS tests, Italic
run: ots-9.1.0-Linux/ots-sanitize build/font.ttf

- name: Compile me twice, shame on me
run: |
rm -rf build
fontc source/GoogleSans/GoogleSans.designspace
cp build/font.ttf ./second-roman.ttf
rm -rf build
fontc source/GoogleSans/GoogleSans-Italic.designspace
cp build/font.ttf ./second-italic.ttf

- name: ttx, it might be handy to troubleshoot
# tail -n +2 to skip past the first line because it emits the filename
run: |
pipx install fonttools
which ttx
ttx --version
diff -u <(ttx -l first-roman.ttf | tail -n +2) <(ttx -l second-roman.ttf | tail -n +2)
diff -u <(ttx -l first-italic.ttf | tail -n +2) <(ttx -l second-italic.ttf | tail -n +2)

rsheeter marked this conversation as resolved.
Show resolved Hide resolved
- name: Stable Roman?
run: cmp first-roman.ttf second-roman.ttf

- name: Stable Italic?
run: cmp first-italic.ttf second-italic.ttf