Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI to expose build instability #656

Merged
merged 8 commits into from
Jan 12, 2024
Merged

CI to expose build instability #656

merged 8 commits into from
Jan 12, 2024

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Dec 14, 2023

Expose #647. This check will fail until we fix that. I also moved build GS to be part of CI because in my mind it is.

@rsheeter rsheeter changed the title [WIP] Try to reproduce build instability CI to expose build instability Dec 14, 2023
@rsheeter rsheeter marked this pull request as ready for review December 14, 2023 05:42
@rsheeter
Copy link
Contributor Author

Rebased on main

@anthrotype
Copy link
Member

I believe it's still going to fail because of varying GSUB FeatureParams nameIDs

@anthrotype
Copy link
Member

anthrotype commented Dec 14, 2023

how about instead of just calling ttx -l you actually diff the output for two ttx -l calls? So it only shows what changed which is what we are interested in

$ diff -u <(pipx run fonttools ttx -l first-roman.ttf) <(pipx run fonttools ttx -l second-roman.ttf)
$ diff -u <(pipx run fonttools ttx -l first-italic.ttf) <(pipx run fonttools ttx -l second-italic.ttf)

@rsheeter
Copy link
Contributor Author

I believe it's still going to fail because of varying GSUB FeatureParams nameIDs

That's right. I don't think we can merge it quite yet.

@anthrotype
Copy link
Member

just rebased on main hoping that things just work

@anthrotype
Copy link
Member

anthrotype commented Dec 18, 2023

looks like gvar and head are still reporting same lengths but different checksums

https://github.com/googlefonts/fontc/actions/runs/7251757185/job/19754763563#step:12:19

Screenshot 2023-12-18 at 17 44 39

@rsheeter
Copy link
Contributor Author

looks like gvar and head are still reporting same lengths but different checksums

Guess we can't declare victory yet. Even so, I'm quite pleased GSUB is now fixed :)

@anthrotype
Copy link
Member

After googlefonts/fontations#750 we can temporarily declare victory ✌️
We need to bump write-fonts first to see the fix but I can confirm that it now works locally (after exporting SOURCE_DATE_EPOCH of course).

@anthrotype
Copy link
Member

with latest write-fonts 0.21.1, CI is now green!

@anthrotype anthrotype added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 7b1691b Jan 12, 2024
10 checks passed
@anthrotype anthrotype deleted the cons branch January 12, 2024 10:02
@anthrotype
Copy link
Member

shall I revert this until we figure out #647 (comment)? otherwise all new PRs are going to fail because of it..

anthrotype added a commit that referenced this pull request Jan 12, 2024
This reverts commit 7b1691b, reversing
changes made to 8849a4f.
anthrotype added a commit that referenced this pull request Jan 12, 2024
This reverts commit 7b1691b, reversing
changes made to 8849a4f.
@rsheeter
Copy link
Contributor Author

I'd vote not, if CI is failing we shouldn't be merging much of anything except a fix and we still have the power to merge despite this failure if we really really want to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants