Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checklist: Get TTX diff matching for oswald #810

Closed
7 of 10 tasks
cmyr opened this issue May 17, 2024 · 1 comment · Fixed by #928
Closed
7 of 10 tasks

checklist: Get TTX diff matching for oswald #810

cmyr opened this issue May 17, 2024 · 1 comment · Fixed by #928

Comments

@cmyr
Copy link
Member

cmyr commented May 17, 2024

Once we get #806 merged, we'll be into the home stretch of matching fontmake for oswald. This issue is intended to track the remaining sources of difference.

Diffs in the normalized markkern layout-normalizer output:

Diffs in GPOS.ttx

  • there are various diffs here that were the original impetus for layout-normalizer: some lookups have different ids for instance, and delta indexes differ. I think long term we want to just use normalizer on this full table, and ignore it?

Diffs in GSUB.ttx

Diffs in GDEF.ttx

  • missing the ligature caret table: (Generate ligature caret table #809)
  • some differences in the GDEF categories; I'm not actually sure how we're generating these, it might be that we're sort of getting it by accident via fea-rs? Some of these differences are related to things like the different handling of digraphs, others will need a bit of investigation. ([marks] Generate GDEF class definitions when none exist #805)
  • the ItemVariationStore differs significantly, but this is probably mostly the result of the GPOS diffs, where we have more deltas because we have more items/rules; we can revisit this after GPOS is matching.
@rsheeter
Copy link
Contributor

Vigorous +1 to normalize GSUB and GPOS then ignore the raw ttx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants